Bug 984724
Summary: | Source rpms may cause > 100% completion percentages in -h output | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> |
Component: | rpm | Assignee: | Panu Matilainen <pmatilai> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | low | Docs Contact: | |
Priority: | unspecified | ||
Version: | 19 | CC: | ffesti, jzeleny, novyjindrich, packaging-team-maint, pknirsch, pmatilai |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | rpm-4.11.3-1.fc20 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-03-26 07:51:18 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ville Skyttä
2013-07-15 20:01:42 UTC
Easily reproduced, probably been broken forever. The issue basically is that source package installation happens through a very different code-path from binary installation, and the counters disagree when both get executed within a single invokation. Lets just say I'm far more tempted to make such mixed binary/source installation an error rather than fiddle with the counters. Mixed binary/source installation is more likely a mistake than intentional, and if nothing else banning it might discourage installing sources as root a little bit. Fixed upstream now, sort of: http://rpm.org/gitweb?p=rpm.git;a=commitdiff;h=4098bfd7fa94c89f70c162c46fcd3627c282a102 Mixed binary+source installation now looks somewhat like this: [root@localhost rpm]# ./rpm -Uvh /tmp/telnet-0.17-58.fc20.x86_64.rpm ~pmatilai/rpmbuild/SRPMS/telnet-*src.rpm Preparing... ################################# [100%] Updating / installing... 1:telnet-1:0.17-58.fc20 ################################# [100%] Updating / installing... 1:telnet-1:0.17-38.fc8 ################################# [100%] 2:telnet-1:0.17-43.fc11 ################################# [100%] 3:telnet-1:0.17-43.fc12 ################################# [100%] [root@localhost rpm]# Ie binaries and sources appear as separate operations, which they certainly are from rpm's POV, and progress no longer exceeds 100%. Its not "perfect" by any means but how many people actually install more than one src.rpm at a time anyway? :) Given this is merely cosmetic, closing as UPSTREAM at this point. It'll make it to Fedora through updates at some point. rpm-4.11.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rpm-4.11.3-1.fc20 rpm-4.11.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rpm-4.11.3-1.fc19 rpm-4.11.3-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. rpm-4.11.3-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. |