Bug 985181

Summary: openstack-nova-novncproxy package provides no pre/post scripts.
Product: [Community] RDO Reporter: Etsuji Nakai <enakai>
Component: openstack-novaAssignee: RHOS Maint <rhos-maint>
Status: CLOSED CURRENTRELEASE QA Contact: Toure Dunnon <tdunnon>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: ndipanov, rbryant
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-30 23:02:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Etsuji Nakai 2013-07-17 03:57:32 UTC 
Description of problem:

Although openstack-nova-novncproxy provides "openstack-nova-novncproxy.service", its preuninstall scriptlet is empty. It should stop the running service before uninstall the package.

# rpm -ql openstack-nova-novncproxy-0.4-6.fc19.noarch
/etc/sysconfig/openstack-nova-novncproxy
/usr/bin/nova-novncproxy
/usr/lib/systemd/system/openstack-nova-novncproxy.service

# rpm -q --scripts openstack-nova-novncproxy-0.4-6.fc19.noarch
postinstall program: /bin/sh
preuninstall program: /bin/sh
Comment 1 Pádraig Brady 2013-07-18 10:42:46 UTC 
https://admin.fedoraproject.org/updates/novnc-0.4-7.fc19,openstack-nova-2013.1.2-4.fc19
Comment 2 Toure Dunnon 2014-06-05 20:01:02 UTC 
#> rpm -qp --scripts openstack-nova-novncproxy-2013.1.2-4.fc19.noarch.rpm
 preuninstall scriptlet (using /bin/sh):
if [ $1 -eq 0 ] ; then
    for svc in novncproxy; do
        /bin/systemctl --no-reload disable openstack-nova-${svc}.service > /dev/null 2>&1 || :
        /bin/systemctl stop openstack-nova-${svc}.service > /dev/null 2>&1 || :
    done
fi
postuninstall scriptlet (using /bin/sh):
/bin/systemctl daemon-reload >/dev/null 2>&1 || :
if [ $1 -ge 1 ] ; then
    # Package upgrade, not uninstall
    for svc in novncproxy; do
        /bin/systemctl try-restart openstack-nova-${svc}.service >/dev/null 2>&1 || :
    done
fi