Bug 985509

Summary: p11-kit: potential hash collision denial of service
Product: Red Hat Enterprise Linux 6 Reporter: Florian Weimer <fweimer>
Component: p11-kitAssignee: Stef Walter <stefw>
Status: CLOSED NOTABUG QA Contact: BaseOS QE Security Team <qe-baseos-security>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.5   
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-07-17 16:11:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 983512    

Description Florian Weimer 2013-07-17 16:04:24 UTC
Murmurhash 3 is broken even with a randomized seed (but the seed is constant in p11-kit, ahem).  This means that its use in the dict implementation is either way overkill, or exposes the code to a denial-of-service issue.  unsigned long/int hashing is collision-prone, too, because it doesn't use a key and actually isn't very hash-like at all.

This isn't a problem as long as the hashes are small, so feel free to close this bug if the hash tables are small.

Comment 1 Stef Walter 2013-07-17 16:11:33 UTC
p11-kit does not hash data from outside of the security context it is run in. So I don't think this is an issue. Denial-of-service would be against self, which cannot be protected against. I'll close this bug, but if I'm wrong, please do reopen.