Bug 985916

* Use %global instead of %define [0]
* BuildRoot not needed since F10 [1]
* Requires in -devel package need %{isa} at the end
* %clean section isn't needed since F13 [2]
* %{buildroot} instead of $RPM_BUILD_ROOT/

More about make install:
make install LIBTOOL=/usr/bin/libtool DESTDIR=$RPM_BUILD_ROOT

Why you're using "LIBTOOL=/usr/bin/libtool" ?
and make install DESTDIR=... can replace with %make_install

[0] https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define
[1] https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
[2] https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean

* %defattr isn't needed since rpm 4.4 [0]

[0] https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

Created attachment 779225 [details]
info about licenses

Fix this and provide new spec and src.rpm please.
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[-]: Package is not known to require ExcludeArch.
[!]: Fully versioned dependency in subpackages, if present.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in compat-
     gtkhtml314-devel
[x]: Package complies to the Packaging Guidelines
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "LGPL (v2) (with incorrect FSF address)", "*No copyright* LGPL (v2 or
     later)", "LGPL (v2 or later)", "LGPL (v2 or later) (with incorrect FSF
     address)", "Unknown or generated". 13 files have unknown license.
     Detailed output of licensecheck in /home/brain/985916-compat-
     gtkhtml314/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 143360 bytes in 6 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

===== SHOULD items =====

Generic:
[!]: Spec use %global instead of %define.
     Note: %define gnome_icon_theme_version 2.22.0 %define gtk2_version 2.20.0
     %define intltool_version 0.36.3 %define gtkhtml_major 3.14
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
     Note: Arch-ed rpms have a total of 2191360 bytes in /usr/share 2191360
     compat-gtkhtml314-3.32.2-2.fc20.x86_64.rpm
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: compat-gtkhtml314-3.32.2-2.fc20.x86_64.rpm
          compat-gtkhtml314-devel-3.32.2-2.fc20.x86_64.rpm
compat-gtkhtml314.x86_64: W: file-not-utf8 /usr/share/doc/compat-gtkhtml314/AUTHORS
compat-gtkhtml314.x86_64: W: no-manual-page-for-binary gtkhtml-editor-test-3.14
compat-gtkhtml314-devel.x86_64: W: no-documentation
compat-gtkhtml314-devel.x86_64: E: incorrect-fsf-address /usr/include/libgtkhtml-3.14/gtkhtml/gtkhtml-embedded.h
2 packages and 0 specfiles checked; 1 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint compat-gtkhtml314 compat-gtkhtml314-devel
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-editor-3.14.so.0.0.0 /lib64/libgmodule-2.0.so.0
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-editor-3.14.so.0.0.0 /lib64/libgconf-2.so.4
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-editor-3.14.so.0.0.0 /lib64/libgailutil.so.18
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-editor-3.14.so.0.0.0 /lib64/libpangocairo-1.0.so.0
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-editor-3.14.so.0.0.0 /lib64/libatk-1.0.so.0
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-editor-3.14.so.0.0.0 /lib64/libgdk_pixbuf-2.0.so.0
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-editor-3.14.so.0.0.0 /lib64/libpangoft2-1.0.so.0
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-editor-3.14.so.0.0.0 /lib64/libpango-1.0.so.0
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-editor-3.14.so.0.0.0 /lib64/libfreetype.so.6
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-editor-3.14.so.0.0.0 /lib64/libfontconfig.so.1
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-editor-3.14.so.0.0.0 /lib64/libgthread-2.0.so.0
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-editor-3.14.so.0.0.0 /lib64/libpthread.so.0
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-3.14.so.19.1.1 /lib64/libenchant.so.1
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-3.14.so.19.1.1 /lib64/libgmodule-2.0.so.0
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-3.14.so.19.1.1 /lib64/libgio-2.0.so.0
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-3.14.so.19.1.1 /lib64/libpangoft2-1.0.so.0
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-3.14.so.19.1.1 /lib64/libfreetype.so.6
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-3.14.so.19.1.1 /lib64/libfontconfig.so.1
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-3.14.so.19.1.1 /lib64/libgthread-2.0.so.0
compat-gtkhtml314.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgtkhtml-3.14.so.19.1.1 /lib64/libpthread.so.0
compat-gtkhtml314.x86_64: W: file-not-utf8 /usr/share/doc/compat-gtkhtml314/AUTHORS
compat-gtkhtml314.x86_64: W: no-manual-page-for-binary gtkhtml-editor-test-3.14
compat-gtkhtml314-devel.x86_64: W: no-documentation
compat-gtkhtml314-devel.x86_64: E: incorrect-fsf-address /usr/include/libgtkhtml-3.14/gtkhtml/gtkhtml-embedded.h
2 packages and 0 specfiles checked; 1 errors, 23 warnings.
# echo 'rpmlint-done:'



Requires
--------
compat-gtkhtml314 (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    gnome-icon-theme
    libatk-1.0.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libenchant.so.1()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libgailutil.so.18()(64bit)
    libgconf-2.so.4()(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgmodule-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgthread-2.0.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libgtkhtml-3.14.so.19()(64bit)
    libgtkhtml-editor-3.14.so.0()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpangoft2-1.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)

compat-gtkhtml314-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    compat-gtkhtml314
    enchant-devel
    iso-codes-devel
    libgtkhtml-3.14.so.19()(64bit)
    libgtkhtml-editor-3.14.so.0()(64bit)
    pkgconfig(enchant)
    pkgconfig(gconf-2.0)
    pkgconfig(gtk+-2.0)
    pkgconfig(iso-codes)
    pkgconfig(libgtkhtml-3.14)



Provides
--------
compat-gtkhtml314:
    compat-gtkhtml314
    compat-gtkhtml314(x86-64)
    libgtkhtml-3.14.so.19()(64bit)
    libgtkhtml-editor-3.14.so.0()(64bit)

compat-gtkhtml314-devel:
    compat-gtkhtml314-devel
    compat-gtkhtml314-devel(x86-64)
    pkgconfig(gtkhtml-editor-3.14)
    pkgconfig(libgtkhtml-3.14)



Source checksums
----------------
http://download.gnome.org/sources/gtkhtml/3.32/gtkhtml-3.32.2.tar.bz2 :
  CHECKSUM(SHA256) this package     : 8746053cf709e1de37c7ac775ab1364ddda4b75167660ed7f98a237b3797e39f
  CHECKSUM(SHA256) upstream package : 8746053cf709e1de37c7ac775ab1364ddda4b75167660ed7f98a237b3797e39f


Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 985916

Manually reviewing the licensing in the files:

gtkhtml/htmlentity.c is listed as "Unknown or generated", it has a clear LGPL2+ header in it, but it is part way down in the file.

ltmain.sh is generated from libtool and does actually have a GPL2+ license header with an exception which says that the generated file can be included under the same terms as the rest of the program.

I don't think it's right or correct to modify the licensing headers of upstream sources, even simply to correct the FSF address.  The license of the sources taken as a whole is pretty clear that it's LGPL2+ for the libraries and GPL2+ for the executables.

Please note also that these exact sources have been distributed by Fedora in the past, continue to be distributed by Fedora in the archives, and newer versions of these sources are currently distributed by Fedora in all current versions up to and including rawhide.  If there's a problem with the licensing here then it really needs to be reviewed for all versions of this package that have been and continue to be distributed by Fedora and will affect many many other packages that depend on these libs as well (both past and present).

SRPM: http://fedorapeople.org/~limb/review/compat-gtkhtml314/compat-gtkhtml314-3.32.2-3.fc20.src.rpm
SPEC: http://fedorapeople.org/~limb/review/compat-gtkhtml314/compat-gtkhtml314.spec

Addresses most of the above.  I agree that the licensing issue should perhaps be filed against the main gtkhtml pacakage, CCIng me, and I'll happily follow their lead.

Igor: is this latest satisfactory or are there other issues that need to be addressed?

Jon: I recommend this change to the spec so that it will build in F18 and 19 as well as 20:

--- rpmbuild.compat-gtkhtml314/SPECS/compat-gtkhtml314.spec~	2013-07-30 03:06:59.000000000 +1200
+++ rpmbuild.compat-gtkhtml314/SPECS/compat-gtkhtml314.spec	2013-08-20 16:50:33.706126882 +1200
@@ -25,7 +25,11 @@
 BuildRequires: gail-devel
 BuildRequires: gettext
 BuildRequires: gnome-common
+%if %{?fedora}0 > 190
 BuildRequires: gnome-icon-theme-devel >= %{gnome_icon_theme_version}
+%else
+BuildRequires: gnome-icon-theme >= %{gnome_icon_theme_version}
+%endif
 BuildRequires: gtk2-devel >= %{gtk2_version}
 BuildRequires: intltool >= %{intltool_version}
 BuildRequires: iso-codes-devel

(In reply to Peter Ajamian from comment #7)

> +%if %{?fedora}0 > 190

The common construct being used in Fedora rpm specs would be
%if 0%{?fedora} > 19

(In reply to Peter Ajamian from comment #6)
> Igor: is this latest satisfactory or are there other issues that need to be
> addressed?
I don't have any questions. All is OK!
Jon, let's roll!

(In reply to Ralf Corsepius from comment #8)
> (In reply to Peter Ajamian from comment #7)
> 
> > +%if %{?fedora}0 > 190
> 
> The common construct being used in Fedora rpm specs would be
> %if 0%{?fedora} > 19

Sure, I'm happy with that.

Great, thanks, I'll add that conditional prior to import.

New Package SCM Request
=======================
Package Name: compat-gtkhtml314
Short Description: GtkHTML library
Owners: limb
Branches: f19 f18
InitialCC:

Git done (by process-git-requests).

compat-gtkhtml314-3.32.2-4.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/compat-gtkhtml314-3.32.2-4.fc19

compat-gtkhtml314-3.32.2-4.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/compat-gtkhtml314-3.32.2-4.fc18

compat-gtkhtml314-3.32.2-4.fc19 has been pushed to the Fedora 19 testing repository.

compat-gtkhtml314-3.32.2-4.fc18 has been pushed to the Fedora 18 stable repository.

compat-gtkhtml314-3.32.2-4.fc19 has been pushed to the Fedora 19 stable repository.