Bug 986712
| Summary: | Review Request: python-cffi - Foreign Function Interface for Python to call C code | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Eric Smith <spacewar> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | i, notting, package-review, samtygier |
| Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-cffi-0.6-4.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-03 23:58:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 833226 | ||
| Bug Blocks: | 986715 | ||
|
Description
Eric Smith
2013-07-21 20:19:21 UTC
Hmm.. You should use http://cffi.readthedocs.org as URL, the current one you are using just represent 0.6 version. I'll take this. Agreed. I'll change that. Thanks for reviewing this one also! Spec URL: http://fedorapeople.org/~brouhaha/python-cffi/python-cffi.spec SRPM URL: http://fedorapeople.org/~brouhaha/python-cffi/python-cffi-0.6-2.fc19.src.rpm URL changed per request. Source0 changed to use version macro. Spec URL: http://fedorapeople.org/~brouhaha/python-cffi/python-cffi.spec SRPM URL: http://fedorapeople.org/~brouhaha/python-cffi/python-cffi-0.6-3.fc19.src.rpm Python 3 support added. 1. python-cffi.i686: E: non-standard-executable-perm /usr/lib/python2.7/site-packages/_cffi_backend.so 0775L
python3-cffi.i686: E: non-standard-executable-perm /usr/lib/python3.3/site-packages/_cffi_backend.cpython-33m.so 0775L
2. Do we need PKG-INFO as %doc?
3. Please report check failure to upstream.
4. Will you push to EL6?
If not please remove
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print (get_python_lib())")}
(optional)
Package is fine, nearly APPROVED.
1. That doesn't happen when built on my system for f19 or built on Koji for rawhide. I think there is some problem on your build machine. This happened with the python-tinycss review also. rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=5653760 $ ls *.rpm python3-cffi-0.6-3.fc20.i686.rpm python-cffi-0.6-3.fc20.i686.rpm python3-cffi-0.6-3.fc20.x86_64.rpm python-cffi-0.6-3.fc20.x86_64.rpm $ rpmlint *.rpm 4 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpm -qlvp *.rpm | egrep \.so -rwxr-xr-x 1 root root 77240 Jul 24 19:54 /usr/lib/python3.3/site-packages/_cffi_backend.cpython-33m.so -rwxr-xr-x 1 root root 84888 Jul 24 19:54 /usr/lib64/python3.3/site-packages/_cffi_backend.cpython-33m.so -rwxr-xr-x 1 root root 72936 Jul 24 19:54 /usr/lib/python2.7/site-packages/_cffi_backend.so -rwxr-xr-x 1 root root 80488 Jul 24 19:54 /usr/lib64/python2.7/site-packages/_cffi_backend.so 2. I don't know whether anyone depends on having PKG-INFO files in Fedora RPMs of Python modules. If not, then PKG-INFO may not be necessary, but since it is provided by 1117 other packages (as determined by "yum provides */PKG-INFO | grep ^Repo | wc -l") I don't think I should remove it. 3. I'll mention the check failure to upstream, but it really isn't their issue since the check passes without any reported errors if I run it manually on the same build system. It's something in how rpmbuild is setting up the environment, which isn't an upstream problem, so I don't intend to deal with it as something that needs to be tracked upstream. Of course, if upstream is able to help with debugging it, that's great. 4. Yes, I plan to push python-cffi to EL6. I really want to get WeasyPrint into EL6, although it looks like that might not be possible, so it may have to wait for EL7. However, at a minimum I want to get as many of the prerequisites into EL6 as possible. Having python-cffi in EL6 is useful for other reasons. OK. Seems I need to cleanup my mock environment ;) APPROVED. New Package SCM Request ======================= Package Name: python-cffi Short Description: Foreign Function Interface for Python to call C code Owners: brouhaha Branches: f18 f19 el6 InitialCC: Git done (by process-git-requests). python-cffi-0.6-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-cffi-0.6-3.fc19 python-cffi-0.6-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-cffi-0.6-3.fc18 python-cffi-0.6-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-cffi-0.6-4.el6 python-cffi-0.6-4.el6 has been pushed to the Fedora EPEL 6 testing repository. python-cffi-0.6-3.fc19 has been pushed to the Fedora 19 stable repository. python-cffi-0.6-3.fc18 has been pushed to the Fedora 18 stable repository. python-cffi-0.6-4.el6 has been pushed to the Fedora EPEL 6 stable repository. Package Change Request ====================== Package Name: python-cffi New Branches: epel7 Owners: brouhaha Git done (by process-git-requests). |