Bug 986895

Summary: [abrt] sigsegv in -T option handling
Product: [Fedora] Fedora Reporter: Pavel Raiskup <praiskup>
Component: tarAssignee: Pavel Raiskup <praiskup>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: kdudka, ovasik, praiskup
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard: abrt_hash:7ec3312b0dfb3e081be168b25aa931191520dbce
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-03-31 05:29:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
File: backtrace
none
File: cgroup
none
File: core_backtrace
none
File: dso_list
none
File: limits
none
File: maps
none
File: open_fds
none
File: proc_pid_status
none
File: var_log_messages none

Description Pavel Raiskup 2013-07-22 11:03:40 UTC 
Description of problem:
This was reported upstream: 
	http://lists.gnu.org/archive/html/bug-tar/2013-07/msg00009.html
Reproducible by (as mentioned upstream):
       cd /tmp; > empty; echo . > valid; tar cf /dev/null -T empty -T valid
It is worth to look at it.

Version-Release number of selected component:
tar-1.26-26.fc19

Additional info:
reporter:       libreport-2.1.5
backtrace_rating: 4
cmdline:        tar cf /dev/null -T empty -T valid
crash_function: strcmp
executable:     /usr/bin/tar
kernel:         3.9.9-301.fc19.x86_64
runlevel:       N 5
uid:            1000

Truncated backtrace:
Thread no. 1 (6 frames)
 #0 strcmp at ../sysdeps/x86_64/multiarch/strcmp-sse42.S:164
 #1 _getopt_internal_r at getopt.c:419
 #2 _getopt_long_r at getopt1.c:54
 #3 parser_parse_next at argp-parse.c:803
 #4 argp_parse at argp-parse.c:925
 #5 decode_options at tar.c:2389
Comment 1 Pavel Raiskup 2013-07-22 11:03:47 UTC 
Created attachment 776859 [details]
File: backtrace
Comment 2 Pavel Raiskup 2013-07-22 11:03:52 UTC 
Created attachment 776860 [details]
File: cgroup
Comment 3 Pavel Raiskup 2013-07-22 11:03:55 UTC 
Created attachment 776861 [details]
File: core_backtrace
Comment 4 Pavel Raiskup 2013-07-22 11:03:58 UTC 
Created attachment 776862 [details]
File: dso_list
Comment 5 Pavel Raiskup 2013-07-22 11:04:02 UTC 
Created attachment 776863 [details]
File: limits
Comment 6 Pavel Raiskup 2013-07-22 11:04:07 UTC 
Created attachment 776864 [details]
File: maps
Comment 7 Pavel Raiskup 2013-07-22 11:04:10 UTC 
Created attachment 776865 [details]
File: open_fds
Comment 8 Pavel Raiskup 2013-07-22 11:04:13 UTC 
Created attachment 776866 [details]
File: proc_pid_status
Comment 9 Pavel Raiskup 2013-07-22 11:04:16 UTC 
Created attachment 776867 [details]
File: var_log_messages
Comment 10 Pavel Raiskup 2013-07-23 11:18:37 UTC 
Fix proposed upstream.
Comment 11 Pavel Raiskup 2013-09-11 13:25:20 UTC 
In the meantime, fix for this bug was pushed upstream as a part of fixing
multiple upstream problems relevant to -T option.  See these upstream changes:

    26538c9bfc5
    6e5e4420f42 (minor)
    ddff3e90388
    95d7b37a34c (minor)
    69007e652ab (minor)
    077d7bceff9 (minor)
    1fe0c83de46
    bff9c3637d9 (minor)

Backpatching all those for so small problem does not seem to be reasonable to
me.  Those changes also caused some changes in -T option handling.
---

The change in behavior is wanted and makes sense, I would say.  But the code
change is too big and touches very base and risky parts of code.  If there was
real user request, I could patch this bug with the small patch I originally
proposed.  But for now, I would wait for official upstream release (taking into
account also that this bug is about unlikely corner case in -T option usage).

Pavel
Comment 12 Fedora Update System 2014-04-01 20:55:23 UTC 
tar-1.26-31.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/tar-1.26-31.fc20