Bug 987132 (php-ZendFramework2)
| Summary: | Review Request: php-ZendFramework2 - Zend Framework 2 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> |
| Component: | Package Review | Assignee: | Gwyn Ciesla <gwync> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, felix, gwync, notting |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | gwync:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | php-ZendFramework2-2.2.5-2.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-11-24 03:44:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Shawn Iwinski
2013-07-22 18:59:18 UTC
Firt, this is 2.2.1, 2.2.4 is out.
- rpmlint checks return:
php-ZendFramework2.spec:10: W: macro-in-comment %{version}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
php-ZendFramework2.spec:10: W: macro-in-comment %{version}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
php-ZendFramework2.spec:11: W: macro-in-comment %{version}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
php-ZendFramework2.spec:11: W: macro-in-comment %{version}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
Fix.
Lots of spelling and nodocs errors, ignorable.
- package meets naming guidelines
- package meets packaging guidelines
- license ( BSD ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
So macros, and most current release, and that's it. Pretty good otherwise.
(In reply to Jon Ciesla from comment #1) > So macros, and most current release, and that's it. Pretty good otherwise. Updated per review: Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-ZendFramework2.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-ZendFramework2-2.2.4-1.fc19.src.rpm Awesome. APPROVED. THANKS for the review! New Package SCM Request ======================= Package Name: php-ZendFramework2 Short Description: Zend Framework 2 Owners: siwinski Branches: f19 f20 el6 InitialCC: Git done (by process-git-requests). php-ZendFramework2-2.2.4-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-ZendFramework2-2.2.4-1.fc20 php-ZendFramework2-2.2.4-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/php-ZendFramework2-2.2.4-1.fc19 php-ZendFramework2-2.2.4-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-ZendFramework2-2.2.4-1.el6 php-ZendFramework2-2.2.4-1.el6 has been pushed to the Fedora EPEL 6 testing repository. php-ZendFramework2-2.2.4-1.fc19 has been pushed to the Fedora 19 stable repository. Package Change Request ====================== Package Name: php-ZendFramework2 New Branches: Owners: siwinski remi heffer InitialCC: php-ZendFramework2-2.2.5-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-ZendFramework2-2.2.5-1.fc20 php-ZendFramework2-2.2.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-ZendFramework2-2.2.5-1.el6 php-ZendFramework2-2.2.5-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/php-ZendFramework2-2.2.5-1.fc19 Misformatted request, clearing flag. php-ZendFramework2-2.2.5-1.el6 has been pushed to the Fedora EPEL 6 testing repository. php-ZendFramework2-2.2.5-2.fc20 has been pushed to the Fedora 20 stable repository. php-ZendFramework2-2.2.5-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |