Bug 987153

1. Do you think adding BR for python-setuptools is OK?

2. %files

%{python_sitelib}/*

should be

%{python_sitelib}/libmodernize
%{python_sitelib}/%{srcname}-%{version}-py%{python_version}.egg-info

3. Remove these

# sitelib for noarch packages, sitearch for others (remove the unneeded one)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}

4. No need to

rm -rf %{buildroot}

Thanks for reviewing!

Spec URL: http://toshio.fedorapeople.org/packages/python-modernize.spec
SRPM URL: http://toshio.fedorapeople.org/packages/python-modernize-0.2-2.fc17.src.rpm

1. Good catch on the BR for python-setuptools.  Added.

2. That's stylistic.  I prefer the wildcard for everything in the directory.  I know that some people would rather be notified if the files in that directory change but I'd rather have the package build succeed and look at the sources when necessary (when updating a stable release).  [One note: you're supposed to add a trailing slash to directories that you own so that it's obvious to people that you meant to include a directory recursively.  So: %{python_sitelib}/libmodernize/ and %{python_sitelib}/%{srcname}-%{version}-py%{python_version}.egg-info/ are correct)

3 & 4.  Thanks!  yeah, I'm only pushing this back as far as EPEL6 (if that) so those are good changes.  Fixed.

Well,

Issue 2 is a problem "Unowned directory".

If you use wildcard, you can include all py files but not directory itself, that's why I want you to change.

What directory is unowned?

%{python_sitelib}/libmodernize itself

The wildcard should include that.  In testing, it looks owned to me:

$ rpm -qpl python-modernize-0.2-2.fc17.noarch.rpm |egrep 'libmodernize$'
/usr/lib/python2.7/site-packages/libmodernize

The '*' wildcard _never_ results in an unowned directory, except if the _parent_ directory (and the parent's parent, and so on) belong into the package. Hence

  %{python_sitelib}/*

includes _anything_ in /usr/lib/python2.7/site-packages/ (and anything includes directories). The guidelines don't comment on that, because that's the trivial case. On the contrary, if it had been

  %{python_sitelib}/libmodernize/*

the "libmodernize" directory would have been unowned:
https://fedoraproject.org/wiki/Packaging:UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory

New Package SCM Request
=======================
Package Name: python-modernize
Short Description: Modernizes Python code for eventual Python 3 migration
Owners: toshio
Branches: f17 f18 f19 devel
InitialCC:

Hmm...You forgot to change the flag...

Git done (by process-git-requests).

python-modernize-0.2-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-modernize-0.2-2.fc19

python-modernize-0.2-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/python-modernize-0.2-2.fc18

Package python-modernize-0.2-2.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-modernize-0.2-2.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-13959/python-modernize-0.2-2.fc18
then log in and leave karma (feedback).

python-modernize-0.2-2.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

python-modernize-0.2-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.