Bug 987223
| Summary: | Review Request: campivisivi-titillium-fonts - Sans-serif typeface designed inside Campi Visivi's Type Design course | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Luya Tshimbalanga <luya> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fonts-bugs, i, notting, package-review |
| Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | campivisivi-titillium-fonts-20120913-2.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-02 21:51:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Luya Tshimbalanga
2013-07-23 02:53:16 UTC
Issues from spec:
1. What's this?
#global archivename %{name}-%{version} ②
2. Remove rm -fr %{buildroot} in install section.
3. Remove %clean section.
(In reply to Christopher Meng from comment #1) > 1. What's this? > > #global archivename %{name}-%{version} ② A comment from the fonts-simple template provided by fontpackager-devel. Now removed from the spec. > > 2. Remove rm -fr %{buildroot} in install section. Done > > 3. Remove %clean section. Done Here is koji result: http://koji.fedoraproject.org/koji/taskinfo?taskID=5642652 Here is rpmlint result: $ rpmlint campivisivi-titillium-fonts.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint campivisivi-titillium-fonts-20120913-2.fc19.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Here is the updated Spec URL: http://luya.fedorapeople.org/packages/SPECS/campivisivi-titillium-fonts.spec SRPM URL: http://luya.fedorapeople.org/packages/SRPMS/campivisivi-titillium-fonts-20120913-2.fc19.src.rpm fontlint is OK; rpmlint is OK; APPROVED. ew Package SCM Request ======================= Package Name: campivisivi-titillium-fonts Short Description: A set of general-purpose & titling open source fonts Owners: luya Branches: f19 f18 el6 InitialCC: fonts-sig No SCM request found. Try re-adding it, with the N at the beginnging. New Package SCM Request ======================= Package Name: campivisivi-titillium-fonts Short Description: A set of general-purpose & titling open source fonts Owners: luya Branches: f19 f18 f17 el6 InitialCC: fonts-sig Git done (by process-git-requests). campivisivi-titillium-fonts-20120913-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/campivisivi-titillium-fonts-20120913-2.fc19 campivisivi-titillium-fonts-20120913-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/campivisivi-titillium-fonts-20120913-2.el6 campivisivi-titillium-fonts-20120913-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/campivisivi-titillium-fonts-20120913-2.fc18 campivisivi-titillium-fonts-20120913-2.el6 has been pushed to the Fedora EPEL 6 testing repository. campivisivi-titillium-fonts-20120913-2.fc18 has been pushed to the Fedora 18 stable repository. campivisivi-titillium-fonts-20120913-2.fc19 has been pushed to the Fedora 19 stable repository. campivisivi-titillium-fonts-20120913-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |