Bug 987457

Summary:	Review Request: rubygem-fast_xs - Provides C extensions for escaping text
Product:	[Fedora] Fedora	Reporter:	Miroslav Suchý <msuchy>
Component:	Package Review	Assignee:	Josef Stribny <jstribny>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	hhorak, jstribny, notting
Target Milestone:	---	Flags:	jstribny: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rubygem-fast_xs-0.8.0-3.fc19	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-08-19 21:29:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Miroslav Suchý 2013-07-23 12:21:41 UTC

Spec URL: http://miroslav.suchy.cz/fedora/rubygem-fast_xs/rubygem-fast_xs.spec
SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-fast_xs/rubygem-fast_xs-0.8.0-2.fc19.src.rpm
Description:
fast_xs provides C extensions for escaping text.
The original String#fast_xs method is based on the xchar code by Sam Ruby:
* http://intertwingly.net/stories/2005/09/28/xchar.rb
* http://intertwingly.net/blog/2005/09/28/XML-Cleansing
_why also packages an older version with Hpricot (patches submitted).
The version here should be compatible with the latest version of Hpricot
code.
Ruby on Rails will automatically use String#fast_xs from either Hpricot
or this gem version with the bundled Builder package.
String#fast_xs is an almost exact translation of Sam Ruby's original
implementation (String#to_xs), but it does escape "&quot;" (which is an
optional, but all parsers are able ot handle it.  XML::Builder as
packaged in Rails 2.0 will be automatically use String#fast_xs instead
of String#to_xs available.

Fedora Account System Username: msuchy

Comment 1 Josef Stribny 2013-08-07 10:27:50 UTC

I will take it for a review.

Comment 2 Josef Stribny 2013-08-07 10:58:21 UTC

Please fix:

* Escape macros in comments
  rubygem-fast_xs.spec:57: W: macro-in-comment %gem_dir

* Description of -doc package should end up with a dot and the description of the main package could a little more formatted (2 line breaks after a paragraph).

Otherwise the spec looks good, it builds, installs & works. Since the issues are minor and could be fixed before pushing I am APPROVING this package.

Comment 3 Miroslav Suchý 2013-08-07 11:30:56 UTC

New Package SCM Request
=======================
Package Name: rubygem-fast_xs
Short Description: Provides C extensions for escaping text
Owners: msuchy
Branches: f19
InitialCC:

Comment 4 Gwyn Ciesla 2013-08-07 12:12:50 UTC

Git done (by process-git-requests).

Comment 5 Fedora Update System 2013-08-07 12:28:41 UTC

rubygem-fast_xs-0.8.0-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/rubygem-fast_xs-0.8.0-3.fc19

Comment 6 Fedora Update System 2013-08-07 23:06:02 UTC

rubygem-fast_xs-0.8.0-3.fc19 has been pushed to the Fedora 19 testing repository.

Comment 7 Fedora Update System 2013-08-19 21:29:07 UTC

rubygem-fast_xs-0.8.0-3.fc19 has been pushed to the Fedora 19 stable repository.