Bug 988086

Summary:	[ExternalTasks] When adding new step, type is always EXECUTING
Product:	[Retired] oVirt	Reporter:	Vojtech Szocs <vszocs>
Component:	ovirt-engine-core	Assignee:	Eli Mesika <emesika>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.3	CC:	acathrow, emesika, iheim, yzaslavs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	infra
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-09-23 07:27:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vojtech Szocs 2013-07-24 17:22:44 UTC

Assume JOB_ID is ID of existing job.

POST https://192.168.122.229/api/jobs/JOB_ID/steps/
<step>
  <description>Test Step</description>
  <type>VALIDATING</type>
  <status>
    <state>STARTED</state>
  </status>
</step>

POST response = step created with type EXECUTING
<step href="/api/jobs/JOB_ID/steps/NEW_STEP_ID" id="NEW_STEP_ID">
    <actions>
        <link href="/api/jobs/JOB_ID/steps/NEW_STEP_ID/end" rel="end"/>
    </actions>
    <description>Step</description>
    <job href="/api/jobs/JOB_ID" id="JOB_ID"/>
    <type>executing</type>
    <number>0</number>
    <status>
        <state>STARTED</state>
    </status>
    <start_time>2013-07-24T16:50:20.061+02:00</start_time>
    <external>true</external>
</step>

If I omit <type> from POST request, I'll get following fault: Step [type] required for add

This makes <type> required in POST request but it doesn't seem to have any effect.

Comment 1 Eli Mesika 2013-08-01 09:25:41 UTC

fixed in commit : 6404cf7

Comment 2 Itamar Heim 2013-08-21 16:40:07 UTC

as RC is built, moving to ON_QA (hopefully did not catch incorrect bugs when doing this)

Comment 3 Itamar Heim 2013-09-23 07:27:22 UTC

closing as this should be in 3.3 (doing so in bulk, so may be incorrect)