Bug 988193

Please remove:

1. rm -rf  %{buildroot} in %install

2. whole %clean section.

3. %defattr(-,root,root,-)

%postun should be:

%postun
if [ $1 -eq 0 ] ; then
         touch --no-create %{_datadir}/icons/elementary-xfce &>/dev/null
         touch --no-create %{_datadir}/icons/elementary-xfce-dark &>/dev/null
         touch --no-create %{_datadir}/icons/elementary-xfce-darker &>/dev/null
         gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce &>/dev/null
         gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce-dark &>/dev/null
         gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce-darker &>/dev/null ||:

%postun
if [ $1 -eq 0 ] ; then
         touch --no-create %{_datadir}/icons/elementary-xfce &>/dev/null
         touch --no-create %{_datadir}/icons/elementary-xfce-dark &>/dev/null
         touch --no-create %{_datadir}/icons/elementary-xfce-darker &>/dev/null
         gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce &>/dev/null
         gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce-dark &>/dev/null
         gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce-darker &>/dev/null ||:
fi

sorry.

Ok, changed that. But I need to head to work now, so will have to do anything else later on today.
Thanks for the quick response!
http://hannes.fedorapeople.org/elementary-xfce-icon-theme.spec
SRPM URL: http://hannes.fedorapeople.org/elementary-xfce-icon-theme-0.3-2.fc19.src.rpm

We don't need %posttrans now, right?

(In reply to hannes from comment #3)
…
> Thanks for the quick response!
…
+1

Ok, added it, since http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache says so.

Spec URL: http://hannes.fedorapeople.org/elementary-xfce-icon-theme.spec
SRPM URL: http://hannes.fedorapeople.org/elementary-xfce-icon-theme-0.3-3.fc19.src.rpm

%post
touch --no-create %{_datadir}/icons/elementary-xfce &>/dev/null ||:
touch --no-create %{_datadir}/icons/elementary-xfce-dark &>/dev/null ||:
touch --no-create %{_datadir}/icons/elementary-xfce-darker &>/dev/null ||:

I think it should be

%post
touch --no-create %{_datadir}/icons/elementary-xfce &>/dev/null
touch --no-create %{_datadir}/icons/elementary-xfce-dark &>/dev/null
touch --no-create %{_datadir}/icons/elementary-xfce-darker &>/dev/null ||:

Why do you think that? Note that all three directories are included in the package.

(In reply to Michael Schwendt from comment #8)
> Why do you think that? Note that all three directories are included in the
> package.

Just keep the same style with postun and posttrans.

Besides this package is approved now.

The scriptlets are wrong, though, and inconsistant.

> Just keep the same style with postun and posttrans.

Better forget about "style" and make them correct.

First of all, don't compare "touch" with "gtk-update-icon-cache". While touch is a coreutils tool, gtk-update-icon-cache may not be installed. That's why you want the scriptlets to _not_ fail when trying to run gtk-update-icon-cache when it isn't found. Secondly, in the odd case that "touch" is not available either, you could not touch the icon dirs, so the scriptlets would fail, too.

> %post
> touch --no-create %{_datadir}/icons/elementary-xfce &>/dev/null ||:
> touch --no-create %{_datadir}/icons/elementary-xfce-dark &>/dev/null ||:
> touch --no-create %{_datadir}/icons/elementary-xfce-darker &>/dev/null ||:

All three dirs are included in the package. And it's proper usage of "|| :" here for allow for a missing "touch" command.

> %postun
> if [ $1 -eq 0 ] ; then
>          touch --no-create %{_datadir}/icons/elementary-xfce &>/dev/null
>          touch --no-create %{_datadir}/icons/elementary-xfce-dark &>/dev/null
>          touch --no-create %{_datadir}/icons/elementary-xfce-darker &>/dev/null
>          gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce &>/dev/null
>          gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce-dark
&>/dev/null
>          gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce-darker
&>/dev/null ||:
> fi

Here, "|| :" should be added at the end of all lines. It makes no sense to add it to just the last line, because the previous two lines would fail already if gtk-update-icon-cache didn't exist. Similarly for "touch".


> %posttrans
>          gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce &>/dev/null
>          gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce-dark
&>/dev/null
>          gtk-update-icon-cache -q %{_datadir}/icons/elementary-xfce-darker
&>/dev/null ||:

Same here. "|| :" at the end of all lines would achieve what it's supposed to do.

(In reply to Michael Schwendt from comment #10)
…
> First of all, don't compare "touch" with "gtk-update-icon-cache". While
> touch is a coreutils tool, gtk-update-icon-cache may not be installed.
> That's why you want the scriptlets to _not_ fail when trying to run
> gtk-update-icon-cache when it isn't found. Secondly, in the odd case that
> "touch" is not available either, you could not touch the icon dirs, so the
> scriptlets would fail, too.
…

I suggest to use 'if [ -x "$file" ]' therefore, where $file means '/usr/bin/touch' and '/usr/bin/gtk-update-icon-cache'. It could skip the whole touch or gtk-update-icon-cache calls individually cause of one false check at the beginning without trying several times to execute something that does not exist or is not marked as executable.

(In reply to Raphael Groner from comment #11)
see also 
http://stackoverflow.com/questions/10319652/check-if-a-file-is-executable
http://www.tldp.org/LDP/Bash-Beginners-Guide/html/sect_07_01.html

Honestly, I would say that touch and gtk-update-icon-cache should be expected to be there on a good working Xfce system.

PS: What if bash is not installed? SCNR.

Do what works for you.

I'm not here to argue about which way to do it or whether a non-existant "touch" is worth supporting. I've only mentioned the purpose of those "|| :". The following page has been pointed at before:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

We don't need to care about bash, in fact they are installed as default in Fedora. Guideline has rules.

New Package SCM Request
=======================
Package Name: elementary-xfce-icon-theme
Short Description: Icons for Xfce based on the elementary Project Icon Theme
Owners: hannes
Branches: f18 f19

Git done (by process-git-requests).

Build in rawhide:
http://koji.fedoraproject.org/koji/buildinfo?buildID=438911

I need to correct myself, since I've been confused. It's the opposite, too many "|| :" in unneeded places, not missing "|| :".

> %post
> touch --no-create %{_datadir}/icons/elementary-xfce &>/dev/null ||:
> touch --no-create %{_datadir}/icons/elementary-xfce-dark &>/dev/null ||:
> touch --no-create %{_datadir}/icons/elementary-xfce-darker &>/dev/null ||:

To allow for a missing touch command, it would be enough to set the exit code at the end:

%post
touch --no-create %{_datadir}/icons/elementary-xfce &>/dev/null
touch --no-create %{_datadir}/icons/elementary-xfce-dark &>/dev/null
touch --no-create %{_datadir}/icons/elementary-xfce-darker &>/dev/null ||:

(In reply to Michael Schwendt from comment #18)

;)