Bug 988283
Summary: | CLI GUI - write attribute dialog for string value should enclose value in generated command to double quotes | ||
---|---|---|---|
Product: | [JBoss] JBoss Enterprise Application Platform 6 | Reporter: | Petr Sakař <psakar> |
Component: | CLI | Assignee: | Alexey Loubyansky <olubyans> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | 6.1.1 | CC: | asaji, chaowan, kkhan, lcosti, nobody, pkremens, rhatlapa, sgilda |
Target Milestone: | DR2 | ||
Target Release: | EAP 6.3.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: |
Attempting to set a value using the `jboss-cli` tool that contained a property would only save the character `$` in the value instead of the property unless the entire value was contained in double-quotes. This was because the CLI command line parser would incorrectly parse any `${X}` expression as only `$` unless it was contained in double-quotes.
The command line parser has been fixed in this release, so that attributes with properties will be correctly parsed even if they are not contained in double-quotes.
|
Story Points: | --- |
Clone Of: | Environment: | ||
Last Closed: | 2014-06-28 15:42:11 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Petr Sakař
2013-07-25 09:01:55 UTC
Issue exists in wildfly as well, and also see this with normal CLI write-attribute operation for attributes like STRING type and expression-allowed => true, Example: /interface=management:write-attribute(name=inet-address,value=${jboss.bind.address.management:127.0.0.1}) From https://github.com/wildfly/wildfly/blob/master/cli/src/main/java/org/jboss/as/cli/ArgumentValueConverter.java?source=c#L71 toSet = ModelNode.fromString(value); This returns 'IllegalArgumentException: Invalid character: $' then '$' is set by ArgumentValueCallbackHandler Create an upstream issue as well https://issues.jboss.org/browse/WFLY-2051 Alexey Loubyansky <alex> made a comment on jira WFLY-2051 It's actually a bug in the CLI command line parser. I.e. it parses any expression like ${xxxx} to simply $. This would fix it https://github.com/aloubyansky/wildfly/commit/255fa8e50a98cae9bffbe7dd60adc6d518548341 Alexey Loubyansky <alex> made a comment on jira WFLY-2051 It's actually a bug in the CLI command line parser. I.e. it parses any expression like ${xxxx} to simply $. This would fix it https://github.com/aloubyansky/wildfly/commit/255fa8e50a98cae9bffbe7dd60adc6d518548341 Alexey Loubyansky <alex> updated the status of jira WFLY-2051 to Resolved Alexey Loubyansky <alex> made a comment on jira WFLY-2051 Fixed. *** Bug 1054214 has been marked as a duplicate of this bug. *** Verified on EAP 6.2.0.DR2 *** Bug 1066228 has been marked as a duplicate of this bug. *** |