Bug 988690

Summary:	oo-accept-node passes when there are migration metadata in gears
Product:	OpenShift Online	Reporter:	Jianwei Hou <jhou>
Component:	Containers	Assignee:	Paul Morie <pmorie>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.x	Keywords:	Regression
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-08-07 22:56:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jianwei Hou 2013-07-26 06:57:32 UTC

Description of problem:
oo-accept-node reports "PASS" when there are migration metadata added in gears.

Version-Release number of selected component (if applicable):
On devenv_3564

How reproducible:
Always

Steps to Reproduce:
1. Create a diy-0.1 app
2. SSH into gear, add migration metadata
in rhcsh, add ".upgrade*" marker under 'app-root/data' dir
3. Run 'oo-accept-node --include-upgrade-checks'

Actual results:
[root@ip-10-151-40-32 data]# pwd
/var/lib/openshift/306246569371548719775744/app-root/data
[root@ip-10-151-40-32 data]# ls -a
.  ..  .bash_history  .bash_profile  .upgrade1  .upgrade11  .upgrade13  .upgrade-32.tst
[root@ip-10-151-40-32 data]# oo-accept-node --include-upgrade-checks -v
INFO: loading node configuration file /etc/openshift/node.conf
INFO: loading resource limit file /etc/openshift/resource_limits.conf
INFO: finding external network device
INFO: checking node public hostname resolution
INFO: checking selinux status
INFO: checking selinux openshift-hosted policy
INFO: checking selinux booleans
INFO: checking selinux nodes
INFO: checking package list
INFO: checking services
INFO: checking kernel semaphores >= 512
INFO: checking cgroups configuration
INFO: checking cgroups processes
INFO: checking filesystem quotas
INFO: checking quota db file selinux label
INFO: checking 1 user accounts
INFO: checking application dirs
INFO: checking system httpd configs
INFO: checking cartridge repository
PASS

Expected results:
Should fail given that the gear has migration metadata

Additional info:

Comment 1 Paul Morie 2013-07-26 18:17:11 UTC

Please re-test; the upgrade metadata now lives in app-root/runtime, which is why accept-node passed in your test.

Comment 2 Jianwei Hou 2013-07-29 08:57:57 UTC

Verified on devenv_3572, oo-accept-node works well to detect the migration metadata, thanks!