Bug 988728
| Summary: | Review Request: chinese-calendar - A Chinese traditional calendar of UbuntuKylin | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Meng <i> |
| Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hdegoede, notting |
| Target Milestone: | --- | Flags: | hdegoede:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | chinese-calendar-0.7.9-1.fc18 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-16 23:03:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Christopher Meng
2013-07-26 09:01:54 UTC
NEW version released. Spec URL: http://cicku.me/chinese-calendar.spec SRPM URL: http://cicku.me/chinese-calendar-0.7.9-1.fc20.src.rpm Good: -------- - rpmlint checks return: chinese-calendar.x86_64: W: no-documentation chinese-calendar.x86_64: W: no-manual-page-for-binary chinese-calendar These can safely be ignored - package meets naming guidelines - package meets packaging guidelines - license (GPLv3) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file Should fix: --------------- - rpmlint checks return: chinese-calendar.x86_64: W: spelling-error %description -l en_US useing -> using, unseeing, segueing chinese-calendar.x86_64: W: desktopfile-without-binary /usr/share/applications/chinese-calendar.desktop /usr/bin/chinese-calendar Please fix the spelling error in %description. The second warning is caused by the .desktop file containing a full-path ( /usr/bin/chinese-calendar) rather then just chinese-calender, would be nice to also fix this. -the spec should run desktop-file-validate on the installed .desktop file (and BuildRequires desktop-file-utils for this). No blockers, approved! Thanks! New Package SCM Request ======================= Package Name: chinese-calendar Short Description: A Chinese traditional calendar of UbuntuKylin Owners: cicku Branches: f18 f19 InitialCC: Git done (by process-git-requests). chinese-calendar-0.7.9-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/chinese-calendar-0.7.9-1.fc19 chinese-calendar-0.7.9-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/chinese-calendar-0.7.9-1.fc18 chinese-calendar-0.7.9-1.fc18 has been pushed to the Fedora 18 testing repository. chinese-calendar-0.7.9-1.fc19 has been pushed to the Fedora 19 stable repository. chinese-calendar-0.7.9-1.fc18 has been pushed to the Fedora 18 stable repository. |