Bug 988818
| Summary: | Review Request: rubygem-xmlhash - A small C module that wraps libxml2's xmlreader to parse a XML string into a ruby hash | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miroslav Suchý <msuchy> |
| Component: | Package Review | Assignee: | Josef Stribny <jstribny> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hhorak, jstribny, notting, package-review |
| Target Milestone: | --- | Flags: | jstribny:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-xmlhash-1.3.5-5.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-15 02:37:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Miroslav Suchý
2013-07-26 13:27:19 UTC
Taking. * Use %%gem_dir to escape macro in comment
rubygem-xmlhash.spec:50: W: macro-in-comment %gem_dir
* Adjust summary
rubygem-xmlhash.src: E: summary-too-long C A small C module that wraps libxml2's xmlreader to parse a XML string into a ruby hash
* Move %doc %{gem_instdir}/README.txt to the main package since it contains licensing information, ideally you could ask upstream to provide a separate license file.
* I believe that /ext files used to build the extension could be probably put into -doc subpackage for clarification.
* Run the test suite with:
testrb -Ilib test/test_xmlhash.rb so the library is properly loaded and tests run.
Other than that I have no complains. It builds, installs and works in mock. Please fix the issues above.
> * I believe that /ext files used to build the extension could be probably put into -doc subpackage for clarification. I would rather keep it just in .src.rpm Other items updated: Spec URL: http://miroslav.suchy.cz/fedora/rubygem-xmlhash/rubygem-xmlhash.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-xmlhash/rubygem-xmlhash-1.3.5-5.fc19.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5778895 APPROVING. New Package SCM Request ======================= Package Name: rubygem-xmlhash Short Description: A small C module to parse a XML string into a ruby hash Owners: msuchy Branches: f19 InitialCC: Git done (by process-git-requests). rubygem-xmlhash-1.3.5-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-xmlhash-1.3.5-5.fc19 rubygem-xmlhash-1.3.5-5.fc19 has been pushed to the Fedora 19 testing repository. rubygem-xmlhash-1.3.5-5.fc19 has been pushed to the Fedora 19 stable repository. |