Bug 989068

Will review in Monday, is it ok for you?

Whenever you have the time works for me :)

Ah really sorry, forgot to do this.

Please update to 1.2 first.

ping.

Pushed dep to stable. Will update this asap.

dep resolved now?

I don't see the 1.2 SRPM yet.

Use pypi as source:

https://pypi.python.org/pypi/google-api-python-client

And the project has been moved to github.

Ping. Any progress on this?

Not yet, will do this later this month when I'm back to work.

Apologies for the delay. Updated spec/srpm:

https://ankursinha.fedorapeople.org/google-api-python-client/google-api-python-client.spec

https://ankursinha.fedorapeople.org/google-api-python-client/google-api-python-client-1.3.1-1.fc23.src.rpm

Thanks,
Ankur

Hi Ankur,

could you update it to 1.4 please? An app I am packaging complains otherwise:
    from apiclient.discovery import build
  File "/usr/lib/python2.7/site-packages/apiclient/__init__.py", line 9, in <module>
    'Previous version of google-api-python-client detected; due to a '
RuntimeError: Previous version of google-api-python-client detected; due to a packaging issue, we cannot perform an in-place upgrade. To repair, remove and re
install this package, along with oauth2client and uritemplate. One can do this with pip via


Cheers,
Michele

Nevermind, ignore the above, brainfart on my part. Having 1.4 would still be nice though ;)

Christopher, are you going to pick up this review?

So after a bit more coffee...

The app I am packaging which uses this google-api-python-client package
does an "import apiclient" which has the following snippet:
try:
  import oauth2client
except ImportError:
  raise RuntimeError(
      'Previous version of google-api-python-client detected; due to a '
      'packaging issue, we cannot perform an in-place upgrade. To repair, '
      'remove and reinstall this package, along with oauth2client and '
      'uritemplate. One can do this with pip via\n'
      '  pip install -I google-api-python-client'
  )


Since we do not have this package in Fedora we error out.

Hence, I am adding the newly created BZ 1228230 as a dependency
Happy to swap reviews there.

Created attachment 1035974 [details]
Updated spec

Here is an updated spec with the following changelog:
%changelog
* Sun Jun 07 2015 Michele Baldessari <michele> - 1.4.0-1
- Update to latest version
- Add python3 package
- Tag LICENSE with appropriate macro


I kind of prefer the name python-google-api-client so the package for python 3
is called python3-google-api-client, like most other packages (instead of
google-api-python3-client)

Note that for the python3 package to work we need BZ 1205170 fixed as well

Hi Michael,

I don't need the package any more. Would you like to take over the review and maintain it? :)

Cheers,
Ankur

Hi Ankur,

thanks for getting back ;) Sure thing I can chown this package and find a reviewer. Are you uninterested in python-uri-templates as well (I ask due to BZ 1205170) or would you like a hand with that as well?

Cheers,
Michele

I don't remember why I was packaging them, so I guess I don't need them anymore. You can take them both if you'd like :)

Spec URL: http://acksyn.org/files/rpms/google-api-python-client/google-api-python-client.spec
SRPM URL: http://acksyn.org/files/rpms/google-api-python-client/google-api-python-client-1.4.0-1.fc22.src.rpm


Fedora Account System Username: mbaldessari

Note that the "Depends On" bugs need to be fixed before this package works correctly.

Spec URL: http://acksyn.org/files/rpms/google-api-python-client/google-api-python-client.spec
SRPM URL: http://acksyn.org/files/rpms/google-api-python-client/google-api-python-client-1.4.1-1.fc22.src.rpm

Christopher, are you still interested in reviewing this?

Resetting to default assignee since more than two months passed without feedback

(In reply to Michele Baldessari from comment #21)
> Spec URL:
> http://acksyn.org/files/rpms/google-api-python-client/google-api-python-
> client.spec
> SRPM URL:
> http://acksyn.org/files/rpms/google-api-python-client/google-api-python-
> client-1.4.1-1.fc22.src.rpm
> 
> Christopher, are you still interested in reviewing this?

No, I was supposed to review Ankur's submission, but not yours.

If you intend to package it, don't reuse existing bug, open a new one and mark this as duplicated, the package however is insipid for me now.

> > Christopher, are you still interested in reviewing this?
> 
> No, I was supposed to review Ankur's submission, but not yours.


No need to be rude here.

Michele, I'd be happy to review your package.

Unfortunately, you need to be the reporter of a package review and unfortunately, the reporter can not be changed. Thus you'd need to report a new bug. Feel free to assign me.

Michele, did you submit a review request for your package?

Hi Paul,

no not yet, thanks for reminding me ;) I'll get to it today or tomorrow

cheers,
Michele

By the way, your python3 package for uri-templates has its %description cut-and-pasted from oauth2client.

Thanks Paul, I've fixed that up. I submitted 1272187 for a new review. If you feel like reviewing that'd be grand. If not, I'll check if Matthias has some spare cycles.

cheers,
Michele