Bug 989293

Summary: Unified naming rules for qemu monitor commands
Product: Red Hat Enterprise Linux 6 Reporter: Xu Tian <xutian>
Component: qemu-kvmAssignee: Virtualization Maintenance <virt-maint>
Status: CLOSED CANTFIX QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.5CC: acathrow, bsarathy, mkenneth, virt-maint
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-08-01 23:24:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Xu Tian 2013-07-29 02:51:00 UTC
Description of problem:

Naming rules of qemu monitor commands is very confused, I thinks it very for hard for qemu tools developer to main a piece of clean code and it's not a good user experience for qemu user too;


(qemu) block
block_resize            blockdev-snapshot-sync  block_passwd            
block_set_io_throttle   block-stream            block-job-set-speed     
block-job-cancel        

Version-Release number of selected component (if applicable):

qemu-kvm-rhev-0.12.1.2-2.379.el6.x86_64

How reproducible:

100%

Steps to Reproduce:
1. boot guest with cmdline:
qemu-kvm -vnc :2 -monitor stdio

2. input "block" in qmp monitor, then type "tab" key 

Actual results:

(qemu) block
block_resize            blockdev-snapshot-sync  block_passwd            
block_set_io_throttle   block-stream            block-job-set-speed     
block-job-cancel

Expected results:

(qemu) block
block_resize            blockdev_snapshot_sync  block_passwd            
block_set_io_throttle   block_stream            block_job_set_speed     
block_job_cancel

Additional info:

we hope to rename monitor command with unified naming rule

Comment 2 Ademar Reis 2013-08-01 23:24:16 UTC
This is something that has been discussed upstream a few times, but unfortunately we can't change all commands without breaking compatibility, and the cost of introducing duplicate names to clean up everything is too high.

What we've been doing is a more careful selection of QMP command names, trying to be consistent in the new commands. Besides, the libvirt API is much more clean and that's what we push users to.

Closing as CANTFIX.