Bug 989627
| Summary: | nodes lib function decompress() strips more than .gz when filename ends in (g|z) | ||
|---|---|---|---|
| Product: | [Retired] Pulp | Reporter: | Jeff Ortel <jortel> |
| Component: | nodes | Assignee: | Jeff Ortel <jortel> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Preethi Thomas <pthomas> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 2.2 Beta | Keywords: | Triaged |
| Target Milestone: | --- | ||
| Target Release: | 2.2.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-10 15:45:24 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
build: 2.2.0-0.23.beta moving to verified <jortel> as for 989627 - 2 things: <jortel> 1. we dont see this in production because the file names dont end in (g|z). really just affected generated tempdir names in unit tests <jortel> 2. in 2.3 this entire module goes away. |
The nodes lib function decompress() strips more than .gz when filename ends in (g|z). Uses rstrip('.gz') which strips the specified characters in any order. This mainly affects the unit tests which fail when generated file names (see: tempfile) end in (g|z) but could cause other issues. Example: /tmp/tmpABCD/tmp123z when compressed is: /tmp/tmpABCD/tmp123z.gz but decompresses to: /tmp/tmpABCD/tmp123. Note trailing 'z' removed.