Bug 989650

Does Ops not care about the description text in the user action log at all regardless of success or failure?

There are 3 classes of log entries here:
1. success
2. validation failures or other user errors
3. failures on account of internal system errors or node failures

I am planning to get rid of the messages in case of internal errors, since they can be long/generic/stack-traces and are anyways found in the broker logs. 

Question: Do you want me to get rid of text messages completely and just have key-value pairs? I would imagine that the messages at the end were helpful to debug any user reported issues since everything other than internal errors are reported as SUCCESS in the user action logs.


Note: Also, I will be adding TIMESTAMP=<epoch_time> and STATUS=[SUCCESS|FAILURE] in the log format, as requested.

Initial fix while Ops responds to the above query.

https://github.com/openshift/origin-server/pull/3213

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/b5d1aaae17ad9eb7c9bfbffca882fe48b25baade
Fix for bug 989650, bug 988115, and added additional check in oo-admin-chk

Fix to incorporate changes suggested by Ops --> https://github.com/openshift/origin-server/pull/3237

Verified on devenv_3588

Now the user_actions.log formant is udpated to key-value pairs, here is what the actual log looks like:
STATUS=SUCCESS TIMESTAMP=1375237289 DATE=2013-07-30 TIME=22:21:29 ACTION=LIST_USER REQ_ID=309ccb46dcc90b8b9dee58669dea58b1 USER_ID=51f86f3553d8ecfcec000001 LOGIN=jhou 
STATUS=SUCCESS TIMESTAMP=1375237289 DATE=2013-07-30 TIME=22:21:29 ACTION=AUTHENTICATE REQ_ID=747c01832bfff385239e20d7021e87d4 USER_ID=51f86f3553d8ecfcec000001 LOGIN=jhou IP=203.114.244.88 SCOPES=session Authenticated
STATUS=SUCCESS TIMESTAMP=1375237289 DATE=2013-07-30 TIME=22:21:29 ACTION=LIST_KEY REQ_ID=747c01832bfff385239e20d7021e87d4 USER_ID=51f86f3553d8ecfcec000001 LOGIN=jhou Found 1 ssh keys
.........
STATUS=SUCCESS TIMESTAMP=1375237754 DATE=2013-07-30 TIME=22:29:14 ACTION=DELETE_APPLICATION REQ_ID=aa22c31fafa9eec1853ea6209a4fd03e USER_ID=51f86f3553d8ecfcec000001 LOGIN=jhou APP=as1 DOMAIN=jhou APP_UUID=bdfde35af98711e2a04e123139401dc0 Application as1 is deleted.


Tried to create a jbossas app and do maven build, found that no maven build logs are appended to user_actions.log. I think this is what the bug requires.
Mark as verified.

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/39f073aca6705bce9eaf0c0180fdf34b4a2d37c6
Fix for bug 989650

(In reply to Hou Jianwei from comment #5)
> Verified on devenv_3588
> 
> Now the user_actions.log formant is udpated to key-value pairs, here is what
> the actual log looks like:
> STATUS=SUCCESS TIMESTAMP=1375237289 DATE=2013-07-30 TIME=22:21:29
> ACTION=LIST_USER REQ_ID=309ccb46dcc90b8b9dee58669dea58b1
> USER_ID=51f86f3553d8ecfcec000001 LOGIN=jhou 
> STATUS=SUCCESS TIMESTAMP=1375237289 DATE=2013-07-30 TIME=22:21:29
> ACTION=AUTHENTICATE REQ_ID=747c01832bfff385239e20d7021e87d4
> USER_ID=51f86f3553d8ecfcec000001 LOGIN=jhou IP=203.114.244.88
> SCOPES=session Authenticated
> STATUS=SUCCESS TIMESTAMP=1375237289 DATE=2013-07-30 TIME=22:21:29
> ACTION=LIST_KEY REQ_ID=747c01832bfff385239e20d7021e87d4
> USER_ID=51f86f3553d8ecfcec000001 LOGIN=jhou Found 1 ssh keys
> .........
> STATUS=SUCCESS TIMESTAMP=1375237754 DATE=2013-07-30 TIME=22:29:14
> ACTION=DELETE_APPLICATION REQ_ID=aa22c31fafa9eec1853ea6209a4fd03e
> USER_ID=51f86f3553d8ecfcec000001 LOGIN=jhou APP=as1 DOMAIN=jhou
> APP_UUID=bdfde35af98711e2a04e123139401dc0 Application as1 is deleted.
> 
> 
> Tried to create a jbossas app and do maven build, found that no maven build
> logs are appended to user_actions.log. I think this is what the bug requires.
> Mark as verified.

What happens on a "STATUS=FAILURE"?

Here is a failure scenario when I have mcollective stopped, there are also some 'unknown' status


RESULT=SUCCESS STATUS=ok TIMESTAMP=1375334369 DATE=2013-08-01 TIME=01:19:29 ACTION=LIST_DOMAIN REQ_ID=43c6ad841397565e8feba2e8780908bf USER_ID=51f9d65559e81d14b5000001 LOGIN=jhou 
RESULT=SUCCESS STATUS=unknown TIMESTAMP=1375334369 DATE=2013-08-01 TIME=01:19:29 ACTION=AUTHENTICATE REQ_ID=6287aebb803b4260e41f351e930f38a9 USER_ID=51f9d65559e81d14b5000001 LOGIN=jhou IP=203.114.244.88 SCOPES=session Authenticated
RESULT=SUCCESS STATUS=ok TIMESTAMP=1375334369 DATE=2013-08-01 TIME=01:19:29 ACTION=LIST_APPLICATION REQ_ID=6287aebb803b4260e41f351e930f38a9 USER_ID=51f9d65559e81d14b5000001 LOGIN=jhou DOMAIN=jhou Found 0 applications.
RESULT=SUCCESS STATUS=ok TIMESTAMP=1375334707 DATE=2013-08-01 TIME=01:25:07 ACTION=LIST_CARTRIDGE REQ_ID=9cdaf13871acccb816a89693ed3d3ae7 USER_ID=51f9d65559e81d14b5000001 LOGIN=jhou List all cartridges
RESULT=SUCCESS STATUS=unknown TIMESTAMP=1375334708 DATE=2013-08-01 TIME=01:25:08 ACTION=AUTHENTICATE REQ_ID=c960af93b7f05d92acb3ec91aed3baed USER_ID=51f9d65559e81d14b5000001 LOGIN=jhou IP=203.114.244.88 SCOPES=session Authenticated
RESULT=SUCCESS STATUS=ok TIMESTAMP=1375334708 DATE=2013-08-01 TIME=01:25:08 ACTION=LIST_DOMAIN REQ_ID=c960af93b7f05d92acb3ec91aed3baed USER_ID=51f9d65559e81d14b5000001 LOGIN=jhou 
RESULT=SUCCESS STATUS=unknown TIMESTAMP=1375334708 DATE=2013-08-01 TIME=01:25:08 ACTION=AUTHENTICATE REQ_ID=1b64f62b797c6b24bd63f00b7e2fc06b USER_ID=51f9d65559e81d14b5000001 LOGIN=jhou IP=203.114.244.88 SCOPES=session Authenticated
RESULT=FAILURE STATUS=service_unavailable TIMESTAMP=1375334713 DATE=2013-08-01 TIME=01:25:13 ACTION=ADD_APPLICATION REQ_ID=1b64f62b797c6b24bd63f00b7e2fc06b USER_ID=51f9d65559e81d14b5000001 LOGIN=jhou DOMAIN=jhou Unable to complete the requested operation because the system is unavailable. If the problem persists please contact Red Hat support.