Bug 990243

Summary:	Building glusterfs should fail when functions are implicitly declared
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	build	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	mainline	CC:	gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.5.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-04-17 11:44:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Niels de Vos 2013-07-30 16:21:59 UTC

It seems that calling undeclared functions do not cause the build to fail. However, the missing function will likely cause issues when the compiled binaries are run.

gcc supports a -Werror=implicit-function-declaration option that could be used for this.

Comment 1 Anand Avati 2013-07-30 16:26:08 UTC

REVIEW: http://review.gluster.org/5435 (build: use -Werror=implicit-function-declaration to detect build issues) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 2 Anand Avati 2013-07-31 03:35:30 UTC

COMMIT: http://review.gluster.org/5435 committed in master by Anand Avati (avati) 
------
commit 7e6432015afd758ca3fd9e32d3e62b29935b0874
Author: Niels de Vos <ndevos>
Date:   Tue Jul 30 18:22:48 2013 +0200

    build: use -Werror=implicit-function-declaration to detect build issues
    
    There have been review requests that include a call to a non-existent
    function. These problems should be detected as early as possible,
    preferably before (automated) regression tests.
    
    Bug: 990243
    Change-Id: Idcf4d27f45a1a6177105d02a039363702eb8e3b9
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/5435
    Reviewed-by: Amar Tumballi <amarts>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 3 Niels de Vos 2014-04-17 11:44:35 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report.

glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user