Bug 991226
| Summary: | Distribute keystone httpd configuration in RPMS | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Young <ayoung> | ||||||||
| Component: | openstack-keystone | Assignee: | Alan Pevec (Fedora) <apevec> | ||||||||
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | low | Docs Contact: | |||||||||
| Priority: | low | ||||||||||
| Version: | 20 | CC: | apevec, ayoung, dpal, ggillies, jlennox, markmc, rbryant, sclewis | ||||||||
| Target Milestone: | --- | Keywords: | Triaged | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | 892420 | Environment: | |||||||||
| Last Closed: | 2015-06-30 00:40:39 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Adam Young
2013-08-01 22:08:53 UTC
Created attachment 782020 [details]
Patch to put HTTPD fiels into the share directory
> Patch to put HTTPD fiels into the share directory Debian does this: "Installs httpd/keystone.py in /usr/share/keystone/wsgi.py as requested by fc__" http://anonscm.debian.org/gitweb/?p=openstack/keystone.git;a=commit;h=bd7205b304ef8ac4adc375d5b0539f7a6437406e Not sure why was that requested, but wouldn't be better to have that in a openstack-keystone-httpd subpackage in the locations expected by httpd i.e. /etc/httpd/conf.modules.d/ or /etc/httpd/conf.d/ (epel6) That approach would be wrong in this case. If a user deploys Keystone as an Eventlet based web service, and deploys Horizon on the same machine, the Keystone file would double-deploy Keystone and provide a potentially broken system. Deploying Keystone into HTTPS is only one potential approach, and is handled post RPM install. Comment on attachment 782020 [details] Patch to put HTTPD fiels into the share directory ok, let's go with sample httpd config in /usr/share/ but please move it to %{_datadir}/keystone/ - I've moved stuff there recently as a part of adding dist.conf in f20/RDO Havana: http://pkgs.fedoraproject.org/cgit/openstack-keystone.git/commit/?id=31f2c501cc1e24b4200df455b38dd6b6bfbfd6f9 Created attachment 806729 [details]
HTTPD files
Created attachment 807198 [details]
HTTPD files
There should be nothing secret in /usr/share/ so changing permissions to 644
Comment on attachment 807198 [details]
HTTPD files
%files section is missing + more follow-up changes, won't post here, see fed pkg git.
Also, I'll propose upstream to rename httpd/keystone.py to httpd/keystone.wsgi to match openstack-dashboard[1] .py is misleading and triggers rpmbuild Python precompile. [1] https://github.com/openstack/horizon/tree/master/openstack_dashboard/wsgi Tested with 640 root:apache /etc/keystone.conf (/etc/keystone/ is not accessible by httpd): [DEFAULT] log_file = onready = admin_token = ADMIN public_port = 8443 admin_port = 8443 public_endpoint = http://localhost:%(public_port)s/keystone/main admin_endpoint = http://localhost:%(admin_port)s/keystone/admin Redoing it to match approach in devstack[1] - run mod_wsgi process under keystone user to avoid separate configuration files. [1] https://github.com/openstack-dev/devstack/commit/a00e5f8810b6ca3b0b5d63cc228125e19bc91955 note to myself: bug 1035032 comment 6 - change header size in httpd config This message is a reminder that Fedora 20 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 20. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '20'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 20 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 20 changed to end-of-life (EOL) status on 2015-06-23. Fedora 20 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |