Bug 991294
Summary: | Review Request: python-appdirs - A small Python module for determining appropriate platform-specific dirs | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Marcelo Barbosa "firemanxbr" <marcelo.barbosa> |
Component: | Package Review | Assignee: | Christopher Meng <i> |
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | echevemaster, i, marcelo.barbosa, package-review, panemade |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-07-27 11:39:10 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449 |
Description
Marcelo Barbosa "firemanxbr"
2013-08-02 05:39:24 UTC
Remove %clean. Hi Christopher, Thank your for review, this package was adjusted: URL SPEC: http://firemanxbr.fedorapeople.org/packages/python-appdirs/python-appdirs.spec URL SRPM: http://firemanxbr.fedorapeople.org/packages/python-appdirs/python-appdirs-1.2.0-2.fc19.src.rpm Marcelo Barbosa - (firemanxbr) If you are tired of find rev of git, you can try https://pypi.python.org/pypi/appdirs as Source0. Issues: 1. python-appdirs.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/appdirs.py 0644L /usr/bin/env. Please check the permission. 2. python-appdirs.noarch: W: incoherent-version-in-changelog 3.2.2-2 ['1.2.0-2.fc20', '1.2.0-2'] Can't understand why you wrote 3.2.2 but not 1.2.0... 3. %files section is incorrect because it has listed egg twice. Please change to %{python_sitelib}/%{pkgname}.* %{python_sitelib}/%{pkgname}-*.egg-info or %{python_sitelib}/* Hi Christopher, Thank your for review again, this package was adjusted: URL SPEC: http://firemanxbr.fedorapeople.org/packages/python-appdirs/python-appdirs.spec URL SRPM: http://firemanxbr.fedorapeople.org/packages/python-appdirs/python-appdirs-1.2.0-3.fc19.src.rpm Marcelo Barbosa - (firemanxbr) READ IT CAREFULLY. 1. python-appdirs.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 4) 2. python-appdirs.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/appdirs.py 0644L /usr/bin/env Requires -------- python-appdirs (rpmlib, GLIBC filtered): /usr/bin/env python(abi) 3. Just got new revised guidelines from FPC, all python2.x stuffs should be renamed to python2 related. So: - %{__python} --> %{__python2} - %{python_sitelib} --> %{python2_sitelib} 4. %{__python} %{_builddir}/%{pkgname}-%{commit}/test/test.py Just use %{__python} test/test.py is enough. 5. MUSTN'T leave macro in %changelog section: * Fri Aug 2 2013 Marcelo Barbosa <mr.marcelo.barbosa> - 1.2.0-2 - Remove %clean - Remove egg-dir in %prep Please double %% them. Marcelo, I don't want to waste my time here. Marcelo it is very bad thing not answer to a reviewer, please if you are not interested anymore in one package please close the review. I need this package and considering all the history above this review qualifies https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews#Submitter_not_responding *** This bug has been marked as a duplicate of bug 1219807 *** |