Bug 991370

Summary: Review Request: python-numpydoc - Sphinx extension to support docstrings in Numpy format
Product: [Fedora] Fedora Reporter: Thomas Spura <tomspur>
Component: Package ReviewAssignee: Christopher Meng <i>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: i, notting, orion, package-review
Target Milestone: ---Flags: i: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: python-numpydoc-0.4-2.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-08-15 02:56:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Thomas Spura 2013-08-02 09:12:59 UTC 
Spec URL: http://tomspur.fedorapeople.org/review/python-numpydoc.spec
SRPM URL: http://tomspur.fedorapeople.org/review/python-numpydoc-0.4-1.fc19.src.rpm
Description:
Numpydoc inserts a hook into Sphinx's autodoc that converts docstrings
following the Numpy/Scipy format to a form palatable to Sphinx.

Fedora Account System Username: tomspur

$ rpmlint /home/tomspur/rpmbuild/SRPMS/python-numpydoc-0.4-1.fc19.src.rpm /home/tomspur/rpmbuild/RPMS/noarch/python-numpydoc-0.4-1.fc19.noarch.rpm /home/tomspur/rpmbuild/RPMS/noarch/python3-numpydoc-0.4-1.fc19.noarch.rpm
python-numpydoc.src: W: spelling-error Summary(en_US) docstrings -> doc strings, doc-strings, drawstrings
python-numpydoc.src: W: spelling-error %description -l en_US autodoc -> auto doc, auto-doc, autodidact
python-numpydoc.src: W: spelling-error %description -l en_US docstrings -> doc strings, doc-strings, drawstrings
python-numpydoc.noarch: W: spelling-error Summary(en_US) docstrings -> doc strings, doc-strings, drawstrings
python-numpydoc.noarch: W: spelling-error %description -l en_US autodoc -> auto doc, auto-doc, autodidact
python-numpydoc.noarch: W: spelling-error %description -l en_US docstrings -> doc strings, doc-strings, drawstrings
python-numpydoc.noarch: W: no-manual-page-for-binary autosummary_generate
python3-numpydoc.noarch: W: spelling-error Summary(en_US) docstrings -> doc strings, doc-strings, drawstrings
python3-numpydoc.noarch: W: spelling-error %description -l en_US autodoc -> auto doc, auto-doc, autodidact
python3-numpydoc.noarch: W: spelling-error %description -l en_US docstrings -> doc strings, doc-strings, drawstrings
python3-numpydoc.noarch: W: no-manual-page-for-binary autosummary_generate
3 packages and 0 specfiles checked; 0 errors, 11 warnings.


The python3 subpackage currently has 2 failing tests. I'd like to have a look on that later on as this package works just fine to build the new python3-matplotlib, and is blocking that update right now.
Comment 1 Christopher Meng 2013-08-05 03:42:34 UTC 
(Drop-by comment)

1. Since Fedora is 19 now, you don't need to add judge script for F12.

2. Replace "BuildRequires:  python-devel" with "BuildRequires:  python2-devel"

3. Replace https://pypi.python.org/packages/source/n/numpydoc/numpydoc-0.4.tar.gz with proper macro, this will save your time for the next version.
Comment 2 Thomas Spura 2013-08-05 07:57:51 UTC 
(In reply to Christopher Meng from comment #1)
> 1. Since Fedora is 19 now, you don't need to add judge script for F12.

This also prevents python3-numpydoc from being build on EPEL.
%if 0{?fedora} would be enough, but with > 12 is on the guidelines page:
http://fedoraproject.org/wiki/Packaging:Python#Subpackages

> 2. Replace "BuildRequires:  python-devel" with "BuildRequires: 
> python2-devel"

Changed

> 3. Replace
> https://pypi.python.org/packages/source/n/numpydoc/numpydoc-0.4.tar.gz with
> proper macro, this will save your time for the next version.

Changed

Further changes:
- Adding some missing BR on nose and sphinx.
- koji scratch built: http://koji.fedoraproject.org/koji/taskinfo?taskID=5777104
- I disabled the python3 package for now as there is currently no upstream support for it. See:
  https://github.com/numpy/numpy/pull/2994
  It will be there in the next version.

Spec URL: http://tomspur.fedorapeople.org/review/python-numpydoc.spec
SRPM URL: http://tomspur.fedorapeople.org/review/python-numpydoc-0.4-2.fc19.src.rpm
Comment 3 Christopher Meng 2013-08-06 05:33:40 UTC 
Package is good.

APPROVED.
Comment 4 Thomas Spura 2013-08-06 08:25:17 UTC 
Thanks for the review.

New Package SCM Request
=======================
Package Name: python-numpydoc
Short Description: Sphinx extension to support docstrings in Numpy format
Owners: tomspur
Branches: f19
InitialCC:
Comment 5 Gwyn Ciesla 2013-08-06 13:18:37 UTC 
Git done (by process-git-requests).
Comment 6 Fedora Update System 2013-08-06 14:04:34 UTC 
python-numpydoc-0.4-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-numpydoc-0.4-2.fc19
Comment 7 Fedora Update System 2013-08-06 23:31:40 UTC 
python-numpydoc-0.4-2.fc19 has been pushed to the Fedora 19 testing repository.
Comment 8 Fedora Update System 2013-08-15 02:56:30 UTC 
python-numpydoc-0.4-2.fc19 has been pushed to the Fedora 19 stable repository.
Comment 9 Orion Poplawski 2015-05-07 21:19:07 UTC 
Thomas - would you maintain this in EPEL please?