Bug 991375

Summary: Should not accept the configuration when it is actually failed in Kdump
Product: Red Hat Enterprise Linux 6 Reporter: wanghui <huiwa>
Component: ovirt-nodeAssignee: Ryan Barry <rbarry>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.5CC: acathrow, bsarathy, cboyle, cshao, fdeutsch, gouyang, hadong, jboggs, leiwang, mburns, ovirt-maint, rbarry, tlavigne, yaniwang, ycui
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-node-3.0.1-8.el6 Doc Type: Bug Fix
Doc Text:
When values for kdump are entered which cause restarting the service to fail, the hypervisor should revert to the previous configuration.
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-21 19:48:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
error configurations none

Description wanghui 2013-08-02 09:26:33 UTC
Description of problem:
It should not accept the configurations when it is actually fail in Kdump.
There are serial scenarios:
1. Provide an unreachable location when configure Kdump with NFS type.(nfs-unreachable-host.png)
2. Provide an unreachable location when configure Kdump with SSH type.(ssh-unreachable-host.png)
3. Provide an error password when configure Kdump with SSH type.(provide-error-password-1.png&provide-error-password-2.png)

Version-Release number of selected component (if applicable):
rhev-hypervisor6-6.5-20130725.0.el6 
ovirt-node-3.0.0-6.1.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1. Enter unreachable location in NFS type like "10:/123".
2. Enter unreachable location in SSH type like "root@10".
3. Provide an error password three times in validation in SSH type.

Actual results:
1. After step1, it persisted the configuration in TUI and /etc/kdump.conf file.
2. After step2, it persisted the configuration in TUI and /etc/kdump.conf file.
3. After step3, it persisted the configuration in TUI and /etc/kdump.conf file.

Expected results:
1.It should not accept the error configuration when providing an error location.
2.It should not persist the configuration when failed valid the password.

Additional info:

Comment 1 wanghui 2013-08-02 09:40:34 UTC
Created attachment 781900 [details]
error configurations

Comment 6 wanghui 2013-10-28 07:47:48 UTC
Test version:
rhevh-6.5-20131024.1.0.iso
ovirt-node-3.0.1-6.el6.noarch

Test steps:
1. Clear install rhevh-6.5-20131024.1.0.iso.
2. Enter unreachable location in NFS type like "10:/".
3. Enter unreachable location in SSH type like "root@10".
4. Provide an error password three times in validation in SSH type.

Test result:
1. After step2/3/4, it will prompt like the follows.
   An error occurred
   KDump configuration failed, location unreachable. Previous configuration was restored.
2. After step2/3/4, it not persisted the configuration in /etc/kdump.conf file.
3. But after step2/3/4, it save the error configuration in TUI.

The error configuration should not be saved in TUI also. So this bug is not fixed totally. Change the status from ON_QA to ASSIGNED.

Comment 8 wanghui 2013-11-04 10:00:30 UTC
Test version:
rhev-hypervisor6-6.5-20131031.1
ovirt-node-3.0.1-7.el6.noarch

Test steps:
1. Clear install rhevh-6.5-20131031.1.0.iso.
2. Enter unreachable location in NFS type like "10:/".

Test result:
1. After step2, it report as follows.
   An error appeared in the UI: Exception('There are not enough arguments given for <function update at 0x29cade8> of <ovirt.node.config.defaults.KDump object at 0x3f3ba50>',)
   Press ENTER to logout ...
   or enter 's' to drop to shell
2. After re-login, the error configuration of kdump is still saved in TUI.

So the bug is not fixed in rhev-hypervisor6-6.5-20131031.1. Change the status from ON_QA to ASSIGNED.

Comment 9 Ryan Barry 2013-11-04 18:23:25 UTC
A fix has been posted, and tested against current downstream images. It seems that the SSH key patches didn't make it, so we were passing too many arguments. It performs as expected with the new patch (no exception, values are cleared).

Comment 11 Cheryn Tan 2013-11-08 00:28:25 UTC
This bug is currently attached to errata RHBA-2013:15277. If this change is not to be documented in the text for this errata please either remove it from the errata, set the requires_doc_text flag to minus (-), or leave a "Doc Text" value of "--no tech note required" if you do not have permission to alter the flag.

Otherwise to aid in the development of relevant and accurate release documentation, please fill out the "Doc Text" field above with these four (4) pieces of information:

* Cause: What actions or circumstances cause this bug to present.
* Consequence: What happens when the bug presents.
* Fix: What was done to fix the bug.
* Result: What now happens when the actions or circumstances above occur. (NB: this is not the same as 'the bug doesn't present anymore')

Once filled out, please set the "Doc Type" field to the appropriate value for the type of change made and submit your edits to the bug.

For further details on the Cause, Consequence, Fix, Result format please refer to:

https://bugzilla.redhat.com/page.cgi?id=fields.html#cf_release_notes 

Thanks in advance.

Comment 12 wanghui 2014-01-13 07:13:41 UTC
Test version:
rhevh-6.5-20140110.1.iso
ovirt-node-3.0.1-16.el6_5.noarch

Test step:
1. Clear install rhevh-6.5-20140110.1.iso
2. Enter unreachable location in NFS type like "10:/".
3. Enter unreachable location in SSH type like "root@10".
4. Enter reachable location in SSH type like "root.1.1" without provide correct password.
5. E

Test result:
1. After step2, it report an error and not save the error configuration in TUI adn /etc/kdump.conf.
2. After step3, it report an error and not save the error configuration in TUI adn /etc/kdump.conf.
3. After step4, it report an error and not save the error configuration in TUI adn /etc/kdump.conf.

So this bug is fixed in rhevh-6.5-20140110.1.iso. Change the status from ON_QA to VERIFIED.

Comment 14 errata-xmlrpc 2014-01-21 19:48:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0033.html