Bug 991398

Summary: namespace creation using oo-admin-ctl-domain requires ssh key input
Product: OpenShift Online Reporter: Nan Wei <nwei>
Component: PodAssignee: Abhishek Gupta <abhgupta>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 2.xCC: abhgupta, jhou, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-08-29 12:49:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Nan Wei 2013-08-02 10:51:36 UTC 
Description of problem:
When creating a namespace by using "oo-admin-ctl-domain" in the broker, it returns “Please provide login, ssh key and namespace to create the user“. Seem like oo-admin-ctl-domain still require user input ssh key. For now, ssh keys and domain are managed separately by rhc client, ssh key is not a must for creating namespace, so oo-admin-ctl-domain should also be updated to do that.
Even when this user already has an existing ssh key, just want to create a namespace, still report the same prompt.

Version-Release number of selected component (if applicable):
devenv-stage_435
devenv_3605

How reproducible:
always

Steps to Reproduce:
1. Ensure a user does not have a namespace.
2.Create a domain in the broker using oo-admin-ctl-domain.
#oo-admin-ctl-domain -c create -l nwei -n domainname

Actual results:
The output of oo-admin-ctl-domain is the following:
Please provide login, ssh key and namespace to create the user

Expected results:
When creating a namespace using oo-admin-ctl-domain, it should not require input ssh key.

Additional info:
Comment 1 Abhishek Gupta 2013-08-19 17:16:41 UTC 
We need to make the ssh key optional. Add it to the user, if it is provided but not treat as a validation failure if it isn't provided.
Comment 2 Abhishek Gupta 2013-08-19 22:43:57 UTC 
Fixed with --> https://github.com/openshift/origin-server/pull/3417
Comment 3 openshift-github-bot 2013-08-19 23:56:42 UTC 
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/e876ea9de4ac82e5b9cbd39059f039e4cdc92f8b
Fix for bug 991398
Comment 5 Jianwei Hou 2013-08-20 05:29:32 UTC 
Verified on devenv_3576, the sshkey is not mandatory now.

[root@ip-10-178-7-176 ~]# oo-admin-ctl-domain -c create -l test -n test
Successfully created user.
Successfully created domain.

[root@ip-10-178-7-176 ~]# oo-admin-ctl-domain -l test

RHLogin: test
Namespace: test
SSH keys:
Applications: