Bug 991470

*** Bug 949291 has been marked as a duplicate of this bug. ***

*** Bug 991739 has been marked as a duplicate of this bug. ***

Here's what I understand from the tests flow and the difference between versions:

The flow:

test#51:
create a storage domain with invalid name (with space)
and with legal storage connection details.

test#52
create a storage domain with valid name and with
the same storage connection details as in test#51  

Results in 3.2:
test#51 fails due to invalid storage domain name
but the storage connection is created anyway due to bug 949291 which I opened a while ago.

test#52 passes because it creates the same storage connection again in the db with different id
(I am pretty sure if you take a look at storage_server_connections table you will find there
2 entries with exact same details except for different connection id.

Results in 3.3:
test#51 fails due to invalid storage domain name
but the storage connection is created due to bug 949291 which I opened a while ago.

test#52 fails due to "connection already exists" error - which is correct because
several months ago this validation was introduced in storage connection creation (not in storage domain creation flow)
to avoid creating several duplicate connections
entries pointing to same storage - to avoid garbage in db and different domains working with same storage.

Conclusions and solutions:
1. storage connection creation in 3.3 avoids adding multiple connections with same details to db by verifying before creation that
another similar connection exists. it's a bug fix/enhancement which is logical and correct to have, and it wasn't there in 3.2.
2. don't use same connection details in different tests. it's not a clean test anyway, unless you are actually trying to
test whether same connection can be recreated more than once. this will immediately solve the problem and hence it's not a test blocker.
3. bug 949291 no doubt needs a solution, but it's not urgent because in 3.3 user can do one of the following in the case storage domain fails due to "connection already exists" error:
a. delete the problematic connection via new option of connection deletion in REST [1]
b. during domain creation supply the existing connection id in REST of storage domain creation (please note this one is in review and is not merged yet, should be any day) [2]

[1]
http://www.ovirt.org/Features/Manage_Storage_Connections#Delete_connection_.28DELETE.29

[2]
http://www.ovirt.org/Features/Manage_Storage_Connections#Add_new_file_.28nfs.2Fposix.2Flocal.29_storage_domain_with_existing_storage_connection_.28POST.29

*** Bug 1018250 has been marked as a duplicate of this bug. ***

POST
URL: https://10.35.163.52/api/storagedomains
BODY:
<storage_domain>
    <name>data1 bla</name>
    <type>data</type>
    <host id="6c3c4675-4294-44ca-ab26-522d16ca5b69"/>
    <storage>
        <type>nfs</type>
        <address>10.35.160.108</address>
        <path>/RHEV/mbourvin</path>
    </storage>
</storage_domain>

RESPONSE:
<fault>
<reason>Operation Failed</reason>
<detail>
[Storage Domain name must be formed of "a-z0-9A-Z" or "-_"]
</detail>
</fault>


POST
URL: https://10.35.163.52/api/storagedomains
BODY:
<storage_domain>
    <name>data1_bla</name>
    <type>data</type>
    <host id="6c3c4675-4294-44ca-ab26-522d16ca5b69"/>
    <storage>
        <type>nfs</type>
        <address>10.35.160.108</address>
        <path>/RHEV/mbourvin</path>
    </storage>
</storage_domain>

RESPONSE:
<storage_domain href= "/api/storagedomains/a7a55634-279f-4252-8458-2597af9efde7" id="a7a55634-279f-4252-8458-2597af9efde7">
<name>data1_bla</name>
<link href= "/api/storagedomains/a7a55634-279f-4252-8458-2597af9efde7/permissions" rel="permissions"/>
<link href= "/api/storagedomains/a7a55634-279f-4252-8458-2597af9efde7/disks" rel="disks"/>
<link href= "/api/storagedomains/a7a55634-279f-4252-8458-2597af9efde7/storageconnections" rel="storageconnections"/>
<type>data</type>
<status>
<state>unknown</state>
</status>
<master>false</master>
<storage>
<address>10.35.160.108</address>
<type>nfs</type>
<path>/RHEV/mbourvin</path>
</storage>
<available>2018634629120</available>
<used>143881404416</used>
<committed>0</committed>
<storage_format>v1</storage_format>
</storage_domain>

Closing as part of 3.4.0