Bug 992224
| Summary: | merkaartor: FTBFS in rawhide(arm) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dennis Gilmore <dennis> |
| Component: | merkaartor | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | kevin, opensource, rdieter, sven |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | merkaartor-0.18.1-8.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-12-14 03:22:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 245418, 991858 | ||
|
Description
Dennis Gilmore
2013-08-05 03:33:18 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle. Changing version to '20'. More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora20 Usual culprit here is the assumption that qreal = double (which is not true on arm) common/Projection.cpp:154:70: error: cannot convert 'qreal* {aka float*}' to 'double*' …
So, yes, it's a qreal issue.
Debian has some fixes for it, but patch-tracker.debian.org (the most convenient way to get at them) is not responding right now.
Looks like we have a winner, http://pkgs.fedoraproject.org/cgit/merkaartor.git/commit/?id=10689f6949b5baa38ba27f4fcc0b8f6bb641319f merkaartor-0.18.1-7.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/merkaartor-0.18.1-7.fc20 That fix from Debian is not correct. You can't just cast a qreal * to (double *). It will make it compile, but it will crash or compute nonsense. ok, update revoked, until we have something better. Just - FYI - unfortunately merkaartor is pretty much dead upstream so I'm thinking about retiring it. Please don't retire it! The package is working fine (except on ARM, and we're looking into that) and is IMHO still the nicest OSM editor out there. Sure, JOSM has more features, but it's also a heavy Java app that's not as nice to use as the Qt-based Merkaartor, and there are also some features Merkaartor has that JOSM doesn't have. (If you really don't want to maintain it, orphan it and let somebody else pick it up. But it's not that much work to keep things running especially when there aren't any new releases to worry about.) For the qreal * vs. double * issue, we need to look at what pointers the callers are actually passing. The easiest fix might be to just change the functions to take double * pointers and making sure the callers are really passing pointers to double, not qreal. If that's impractical, then the conversion has to be made in the projTransform* wrapper functions. Should be better now: http://pkgs.fedoraproject.org/cgit/merkaartor.git/commit/?id=71b8c5bbfd44e68cfbbbe1ace2861508657e62c1 merkaartor-0.18.1-8.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/merkaartor-0.18.1-8.fc20 Package merkaartor-0.18.1-8.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing merkaartor-0.18.1-8.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-22755/merkaartor-0.18.1-8.fc20 then log in and leave karma (feedback). merkaartor-0.18.1-8.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |