Bug 993445

Summary:	User can successfully upload a txt file that doesn't exist
Product:	[Retired] Zanata	Reporter:	Damian Jansen <djansen>
Component:	Component-Logic	Assignee:	David Mason <damason>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Zanata-QA Mailling List <zanata-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	development	CC:	djansen, zanata-bugs
Target Milestone:	---
Target Release:	3.5
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	3.5.0-SNAPSHOT	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-01-26 23:27:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Damian Jansen 2013-08-06 00:26:46 UTC

Description of problem:
If, for whatever reason, a txt file is moved or deleted while an admin is in the process of uploading, the file is still created on the server sans content of the original file.

Version-Release number of selected component (if applicable):
Dev

How reproducible:
Easy always

Steps to Reproduce:
1. Have a txt file on system with some content, echo "Blah whatever" >testfile.txt
2. Sign in as admin/maintainer
3. Go to a project, project version
4. Go to Source Documents, select Upload Document
5. Click browse, navigate to and select the testfile.txt
6. With the Upload dialog still in view, move or delete the testfile.txt
7. Press Upload

Actual results:
File is uploaded. Downloading this file results in an empty file being received.

Expected results:
Transaction failed.

Additional info:
This seems to occur only on Chrome and with a specific set of profile settings in Firefox. Pressing Upload in Firefox seemingly has no action other than a page reload.

Comment 1 Damian Jansen 2014-08-11 06:38:14 UTC

Fixed by https://github.com/zanata/zanata-server/commit/5b76932142d18da8ab16a5d4a08acbd58d72ed37

Comment 2 David Mason 2014-08-11 23:49:48 UTC

Since the multi-file upload dialog is only used in one of a few upload locations, I suspect that commit may not completely fix this issue. Am I mistaken about this?

Comment 3 Damian Jansen 2014-11-19 05:41:50 UTC

I think the other instances are handled differently.