Bug 993990
| Summary: | nagios-plugins-bdii possibly affected by F-20 unversioned docdir change | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> | ||||
| Component: | nagios-plugins-bdii | Assignee: | Laurence Field <Laurence.Field> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 20 | CC: | Laurence.Field, steve.traylen | ||||
| Target Milestone: | --- | Keywords: | Patch | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | http://fedoraproject.org/wiki/Changes/UnversionedDocdirs | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | nagios-plugins-bdii-1.0.15-2.fc21 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2015-05-30 09:02:38 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 993551 | ||||||
| Attachments: |
|
||||||
This has been fixed in the master It's not fixed, now the build will actually fail:
RPM build errors:
error: File not found: /builddir/build/BUILDROOT/nagios-plugins-bdii-1.0.14-5.fc20.x86_64/usr/share/doc/LICENSE
File not found: /builddir/build/BUILDROOT/nagios-plugins-bdii-1.0.14-5.fc20.x86_64/usr/share/doc/LICENSE
For example this would fix it for real:
diff --git a/nagios-plugins-bdii.spec b/nagios-plugins-bdii.spec
index 9b4dc0b..a16e517 100644
--- a/nagios-plugins-bdii.spec
+++ b/nagios-plugins-bdii.spec
@@ -28,0 +29 @@ make install prefix=%{buildroot}
+rm -rf %{buildroot}%{_docdir}
@@ -33 +34 @@ make install prefix=%{buildroot}
-%{_defaultdocdir}/LICENSE
+%doc LICENSE
Sorry, have provided a new version. Created attachment 783955 [details]
Another suggested fix
Now there's a problem that the package specific doc dir (/usr/share/doc/nagios-plugins-bdii) is not owned by this package. Again, the attached patch would fix it without downsides...
I have applied and tested the patch. Thanks. This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle. Changing version to '20'. More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora20 Looks like this has been fixed in git but not builds have been made. Is that on purpose? Yes, this only targets EPEL 5 and 6. This message is a reminder that Fedora 20 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 20. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '20'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 20 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. |
nagios-plugins-bdii was identified as a package possibly needing maintainer attention due to the F-20 unversioned doc dir change. The identification is not foolproof, it is basically this grep: grep -E "(/doc|_docdir|_defaultdocdir).+version" *.spec Please review your package and make the appropriate changes, if any. A good starting point is checking the lines output by the above grep for your specfile. For the vast majority of packages, after the changes, the expected outcome is that documentation dirs in /usr/share/doc should no longer contain the package version. More information and tips: https://fedoraproject.org/wiki/Changes/UnversionedDocdirs http://thread.gmane.org/gmane.linux.redhat.fedora.devel/183942/focus=183943 http://thread.gmane.org/gmane.linux.redhat.fedora.devel/183942/focus=183973