Bug 994044

Summary:	cli: --timeout should accept time specifiers
Product:	Red Hat Enterprise Linux 7	Reporter:	Tomas Dolezal <todoleza>
Component:	firewalld	Assignee:	Thomas Woerner <twoerner>
Status:	CLOSED ERRATA	QA Contact:	Tomas Dolezal <todoleza>
Severity:	unspecified	Docs Contact:
Priority:	low
Version:	7.0	CC:	hkario, jpopelka, jscotka, todoleza
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	firewalld-0.3.9-8.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-03-05 13:22:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	980210

Description Tomas Dolezal 2013-08-06 14:02:46 UTC

Description of problem:
* --timeout should accept time specifiers like minute, hour, day or week

Version-Release number of selected component (if applicable):
firewalld-0.3.4-1

How reproducible:
always

Steps to Reproduce:
firewall-cmd --add-service=http --timeout 4m

Expected results:
please fix or provide information why do you think it shouldn't be fixed this way
thanks

Additional info:
CCed affiliated users

Comment 3 Thomas Woerner 2013-08-06 15:50:57 UTC

The timeout is handled by firewalld and not by netfilter. firewalld removes all rules and netfilter helpers, that have been added to activate the feature with the timeout after it timed out.

If you enable for example port forwarding, this is more than one rule and depends also on the target (if it gets forwarded locally or not). netfilter is not able to handle this in a good and usable way.

The timeout is used in the same way in the command line client and also in the D-Bus interface: As a natural number. Allowing the use of other values than seconds in the command line client will not be doable with the current D-Bus interface.

Comment 4 Tomas Dolezal 2013-08-07 12:37:57 UTC

Isn't it possible to translate the value from e.g. hours to seconds before sending it over D-Bus?
If only seconds are possible, then user would need to use something like this:
firewall-cmd --add-service http --timeout $((4*60*60)) to achive 4h value.

Comment 5 Thomas Woerner 2013-11-12 12:23:35 UTC

Moving to 7.1.

Comment 7 Jiri Popelka 2014-06-17 17:18:59 UTC

Upstream commit:
https://git.fedorahosted.org/cgit/firewalld.git/commit/?id=dd77e17ea844948094f3c2c5348dfa762051858e

Comment 12 errata-xmlrpc 2015-03-05 13:22:44 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0520.html