Bug 994419

Summary: [origin_runtime_175]Client message messes up if gear space is used more than 90%
Product: OpenShift Online Reporter: Qiushui Zhang <qiuzhang>
Component: PodAssignee: Lili Nader <lnader>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: low Docs Contact:
Priority: medium    
Version: 2.xCC: mfisher, nduong, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-30 00:48:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
output when the command window is max size
none
output when the command window is not in max size none

Description Qiushui Zhang 2013-08-07 09:06:42 UTC 
Description of problem:
The message returned messes up if gear space is used more than 90%

Version-Release number of selected component (if applicable):
devenv_3622
rhc-1.13.0 built from devenv_3622

How reproducible:
always

Steps to Reproduce:
1. Create an app
2. SSH into the app. Add a file which takes more than 90% of gear's total space.
e.g for an app without additional storage, dd if=/dev/zero of=testfile bs=1M count=950
3. rhc app show $appname --gears

Actual results:
520206208fd4a70cac000001 startedCLIENT_MESSAGE: Warning gear 520206208fd4a70cac000001 is using 92.84400939941406 of disk quota  php-5.3    small 520206208fd4a70cac000001.rhcloud.com

Expected results:
The "CLIENT_MESSAGE" should be shown after/before the gear info in a new line

Additional info:
Comment 1 Abhishek Gupta 2013-08-19 19:07:31 UTC 
On the broker side, we need to make sure that any messages included in the mcollective response are not mixed with the "state" of the gear in the REST response from the broker.
Comment 2 Lili Nader 2013-08-19 23:49:14 UTC 
https://github.com/openshift/origin-server/pull/3418
Comment 3 openshift-github-bot 2013-08-20 18:15:40 UTC 
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/18f633dc0756251174fa95895907fd27bc3f14bf
Bug 994419
Comment 4 Qiushui Zhang 2013-08-21 02:27:36 UTC 
Created attachment 788691 [details]
output when the command window is max size
Comment 5 Qiushui Zhang 2013-08-21 02:28:49 UTC 
Created attachment 788692 [details]
output when the command window is not in max size

Checked on devenv_3680. I got the output like the attached screenshot. I have two concerns about the output:
1. The content "php-5.3    small e3ee8cac0a0511e3af8912313b0a852c.rhcloud.com" should not be in yellow color, since it is not part of the warning message. They are only normal message about "Cartridges, Size and  SSH URL"

2. The output format (when the window is not large enough) is not looking so good.
Comment 6 Lili Nader 2013-10-14 22:52:48 UTC 
https://github.com/openshift/origin-server/pull/3886
Comment 7 openshift-github-bot 2013-10-22 08:15:39 UTC 
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/67d4311690543a69db907e17b4f1d06185e0ba53
Bug 994419
Comment 8 Qiushui Zhang 2013-10-23 03:13:26 UTC 
Tested on devenv_3932.
The client message is printed in a separate line. Looks much better than before.
openshift@openshift-ubuntu:~$ rhc app show rb --gears
Warning gear 52673db26d6c465ab4000007 is using 92.9% of disk quota
ID                       State   Cartridges Size  SSH URL
------------------------ ------- ---------- ----- ----------------------------------------------------
52673db26d6c465ab4000007 started ruby-1.9   small 52673db26d6c465ab4000007.rhcloud.com

Mark the bug as verified.
Comment 9 Jordan Liggitt 2013-10-23 16:27:04 UTC 
*** Bug 1020076 has been marked as a duplicate of this bug. ***