Bug 994543 (kdesdk-kioslaves)

Summary:	Review Request: kdesdk-kioslaves - KDE KIOslaves for perldoc and subversion
Product:	[Fedora] Fedora	Reporter:	Jan Grulich <jgrulich>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	kevin, notting, package-review, rdieter
Target Milestone:	---	Flags:	rdieter: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-08-14 13:38:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	656997

Description Jan Grulich 2013-08-07 13:28:37 UTC

Spec URL: http://jgrulich.fedorapeople.org/kdesdk-kioslaves.spec
SRPM URL: http://jgrulich.fedorapeople.org/kdesdk-kioslaves-4.10.97-1.fc19.src.rpm
Description: KDE SDK kioslaves
Fedora Account System Username: jgrulich

Successful build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5789720

This package was previously part of kdesdk. Now it's distributed separately in KDE 4.11.

Comment 1 Rex Dieter 2013-08-07 13:54:48 UTC

Need add
Obsoletes: kdesdk-kdesdk-kioslave < 7:4.10.80

and fix provides (no 's' in previous subpkg name):
Provides:  kdesdk-kdesdk-kioslave = 7:%{version}-%{release}

Comment 2 Rex Dieter 2013-08-07 13:55:28 UTC

Just checked, prior kdesdk pkg had no epoch, so need to leave out the 7: parts

Comment 3 Jan Grulich 2013-08-07 14:02:33 UTC

Ok, fixed

Spec URL: http://jgrulich.fedorapeople.org/kdesdk-kioslaves.spec
SRPM URL: http://jgrulich.fedorapeople.org/kdesdk-kioslaves-4.10.97-1.fc19.src.rpm

Comment 4 Kevin Kofler 2013-08-11 17:41:09 UTC

Please be more specific in the Summary/Description about what kind of KIO slaves are contained in this package. (See the description of the dolphin-plugins.)

Comment 5 Jan Grulich 2013-08-13 07:39:05 UTC

Updated Summary/Description

Spec URL: http://jgrulich.fedorapeople.org/kdesdk-kioslaves.spec
SRPM URL: http://jgrulich.fedorapeople.org/kdesdk-kioslaves-4.10.97-1.fc19.src.rpm

Comment 6 Rex Dieter 2013-08-13 22:41:01 UTC

naming: ok

1. better url:
https://projects.kde.org/projects/kde/kdesdk/kdesdk-kioslaves

2. drop epoch from Conflicts, should be:
Conflicts: kdesdk-common < 4.10.80

3. license not ok
perldoc is GPLv2
svn includes both GPLv2+ LGPLv2+, aggregate GPLv2+, so
# perldoc is GPLv2, svn GPLv2+
License: GPLv2 and GPLv2+

macros: ok

4. scriptlets: SHOULD drop not-needed
update-mime-database
from scriptlets

5. dependencies: SHOULD drop unused,
BuildRequires:  desktop-file-utils

Comment 7 Jan Grulich 2013-08-14 05:16:13 UTC

Updated

Spec URL: http://jgrulich.fedorapeople.org/kdesdk-kioslaves.spec
SRPM URL: http://jgrulich.fedorapeople.org/kdesdk-kioslaves-4.11.0-1.fc19.src.rpm

Comment 8 Rex Dieter 2013-08-14 11:46:12 UTC

Thanks, APPROVED

Comment 9 Jan Grulich 2013-08-14 11:48:37 UTC

New Package SCM Request
=======================
Package Name: kdesdk-kioslaves
Short Description: KDE KIOslaves for perldoc and subversion
Owners: than rdieter kkofler ltinkl jgrulich
Branches: f18 f19
InitialCC:

Comment 10 Gwyn Ciesla 2013-08-14 12:52:38 UTC

Git done (by process-git-requests).