Bug 994727
Summary: | Samba hook script adds redundant sections in smb.conf | ||
---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Raghavendra Talur <rtalur> |
Component: | scripts | Assignee: | Raghavendra Talur <rtalur> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | pre-release | CC: | gluster-bugs, rabhat, rhs-bugs, rwheeler, vagarwal, vbellur, vinaraya |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | glusterfs-3.5.0 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | 852140 | Environment: | |
Last Closed: | 2014-04-17 11:45:32 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 844761, 852140 | ||
Bug Blocks: | 858434 |
Comment 1
Anand Avati
2013-08-07 21:54:29 UTC
COMMIT: http://review.gluster.org/5526 committed in master by Anand Avati (avati) ------ commit 993001dadf3b1706816b7762749a4c4426ac86df Author: Raghavendra Talur <rtalur> Date: Thu Aug 8 03:19:43 2013 +0530 extras/hook-scripts: Don't add multiple entries in smb.conf When volume is force started, there may be entry in smb.conf for that volume. Always check for entry before adding one. Change-Id: I44f893174a993abaa31c24c1a81bb38a58617808 BUG: 994727 Signed-off-by: Raghavendra Talur <rtalur> Reviewed-on: http://review.gluster.org/5526 Reviewed-by: Anand Avati <avati> Tested-by: Anand Avati <avati> REVIEW: http://review.gluster.org/6043 (extras/hookscripts: Fix the multiple entries in smb.conf problem.) posted (#1) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/6043 (extras/hookscripts: Fix the multiple entries in smb.conf problem.) posted (#2) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/6043 (extras/hookscripts: Fix the multiple entries in smb.conf problem.) posted (#3) for review on master by Raghavendra Talur (rtalur) COMMIT: http://review.gluster.org/6043 committed in master by Anand Avati (avati) ------ commit 11bb1fc5849a557d1a26e59bd651fbd0d07a1b8d Author: Raghavendra Talur <rtalur> Date: Mon Oct 7 13:08:49 2013 +0530 extras/hookscripts: Fix the multiple entries in smb.conf problem. Problem: 1. Force starts and user.smb sets were adding multiple entries to the smb.conf file for the same volume. Make a check for the entry and search with exact name. 2. Again, while deleting the share name from smb.conf search with exact name so that volumes with names which are substrings of ones to be deleted don't get deleted. 3. We don't need to use a tmp file while using sed -i, fixed that. Change-Id: Ie0f7c9d4790ef9a177a043378a761c9ffe1628e5 BUG: 994727 Signed-off-by: Raghavendra Talur <rtalur> Reviewed-on: http://review.gluster.org/6043 Reviewed-by: Niels de Vos <ndevos> Reviewed-by: Lalatendu Mohanty <lmohanty> Tested-by: Lalatendu Mohanty <lmohanty> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report. glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |