Bug 995444
| Summary: | Review Request: glassfish-websocket-api - JSR 356: Java API for WebSocket | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | gil cattaneo <puntogil> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, tcallawa |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | tcallawa:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-11-22 02:23:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
gil cattaneo
2013-08-09 11:41:36 UTC
Spec URL: http://gil.fedorapeople.org/glassfish-websocket-api.spec SRPM URL: http://gil.fedorapeople.org/glassfish-websocket-api-1.1-1.fc22.src.rpm - update to 1.1 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10890303 Spec URL: http://gil.fedorapeople.org/glassfish-websocket-api.spec SRPM URL: http://gil.fedorapeople.org/glassfish-websocket-api-1.1-1.fc23.src.rpm gil's scratch build of glassfish-websocket-api-1.1-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11726632 Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (CDDL or GPLv2 with exceptions) OK, text in %license, matches source - spec file legible, in am. english - source matches upstream (30944ba6a3826f39259279df7b90a3f0df41d47e9fd48fbc28c1feef13ea39fe) - package compiles on f23 (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - javadoc ok - nothing in %doc affects runtime - no need for .desktop file One minor issue here. The license should be: CDDL or GPLv2 with exceptions but your tag has: CDDL and GPLv2 with exceptions Please fix that before import. APPROVED (In reply to Tom "spot" Callaway from comment #4) > One minor issue here. The license should be: > > CDDL or GPLv2 with exceptions > > but your tag has: > > CDDL and GPLv2 with exceptions > > Please fix that before import. Done. Spec URL: http://gil.fedorapeople.org/glassfish-websocket-api.spec SRPM URL: http://gil.fedorapeople.org/glassfish-websocket-api-1.1-1.fc23.src.rpm Thanks! Request for new package: https://admin.fedoraproject.org/pkgdb/package/requests/1462 https://admin.fedoraproject.org/pkgdb/package/requests/1463 Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/glassfish-websocket-api I believe that this bug is fixed in glassfish-websocket-api-1.1-1.fc24, So I am closing this bug now. Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=11794329 glassfish-websocket-api-1.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-be94439d02 glassfish-websocket-api-1.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update glassfish-websocket-api' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-be94439d02 glassfish-websocket-api-1.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |