Bug 995864 (liblinear)
| Summary: | Review Request: liblinear - Library for Large Linear Classification | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Björn 'besser82' Esser <besser82> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | i, notting |
| Target Milestone: | --- | Flags: | i:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | liblinear-1.93-2.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-18 21:32:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Björn 'besser82' Esser
2013-08-11 16:13:57 UTC
%doc COPYRIGHT appeared twice. I think just put it in main pkg is ok. (In reply to Christopher Meng from comment #1) > %doc COPYRIGHT appeared twice. > > I think just put it in main pkg is ok. Why? Can you share your thoughs in a bit more elaborated sentence, please? I think having COPYRIGHT in base and doc-pkg is a must to meet the guidelines from [1]. The doc-subpkg has, apart from the others, no deps on any pkg. Documentation should not require some binary-pkg, because most people want to read docs BEFORE installing the binary. [1] http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing What I don't understand is why the Python subpackages don't use %?_isa? https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package $ rpm -qR python-liblinear|grep -v ^rpm liblinear = 1.93-1.fc19 python(abi) = 2.7 The Python module strictly needs the arch-specific lib using a specific SONAME. (In reply to Michael Schwendt from comment #3) > What I don't understand is why the Python subpackages don't use %?_isa? > https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > > $ rpm -qR python-liblinear|grep -v ^rpm > liblinear = 1.93-1.fc19 > python(abi) = 2.7 > > The Python module strictly needs the arch-specific lib using a specific > SONAME. Thanks for the hint, Michael! Didn't mind that, unfortunately. :( Fixed in updated spec-file below. ##### Changelog: * Mon Aug 12 2013 Björn Esser <bjoern.esser> - 1.93-2 - build arched python-plugins - nuke hashbang from python-plugins * Sun Aug 11 2013 Björn Esser <bjoern.esser> - 1.93-1 - Initial rpm release Urls: Spec URL: http://besser82.fedorapeople.org/review/liblinear.spec SRPM URL: http://besser82.fedorapeople.org/review/liblinear-1.93-2.fc19.src.rpm I'm eating libraries. Will review it later. http://www.csie.ntu.edu.tw/~cjlin/liblinear/exp.html : CHECKSUM(SHA256) this package : 55a00eea6b597d7bef77165dd7d6e91398cacd185afcaf63cb048a555102bc9f CHECKSUM(SHA256) upstream package : 84b2ca3abffea689b3b6eb3b8f40e6c62b12f285f394630b9ade4dcb080bc48d I don't know what happened here, but please update it again. SUGGESTION: SPEC SHOULD CONTAIN FULL URL WITHOUT ANY MACROS, THIS WILL HELP OTHERS FIND THE URL QUICKLY, DON'T NEED TO WASTE TIME OF REPLACING THE MACRO WITH NAME. APPROVED. (In reply to Christopher Meng from comment #6) > http://www.csie.ntu.edu.tw/~cjlin/liblinear/exp.html : > CHECKSUM(SHA256) this package : > 55a00eea6b597d7bef77165dd7d6e91398cacd185afcaf63cb048a555102bc9f > CHECKSUM(SHA256) upstream package : > 84b2ca3abffea689b3b6eb3b8f40e6c62b12f285f394630b9ade4dcb080bc48d > > I don't know what happened here, but please update it again. Seems like some update on project's hp. Regenerated srpm without bumping revision. Should be fixed now. Source checksums ---------------- http://www.csie.ntu.edu.tw/~cjlin/liblinear/index.html : CHECKSUM(SHA256) this package : 51dfdb61923d226637c0471189025bb77380e67a5fab0054af60ede8bd221412 CHECKSUM(SHA256) upstream package : 51dfdb61923d226637c0471189025bb77380e67a5fab0054af60ede8bd221412 http://www.csie.ntu.edu.tw/~cjlin/liblinear/FAQ.html : CHECKSUM(SHA256) this package : 1f4d162510b2358bda122b74e579b96d443d87e6c83c5822dca7dde5ffd12768 CHECKSUM(SHA256) upstream package : 1f4d162510b2358bda122b74e579b96d443d87e6c83c5822dca7dde5ffd12768 http://www.csie.ntu.edu.tw/~cjlin/liblinear/liblinear-1.93.tar.gz : CHECKSUM(SHA256) this package : 76c542aa056bd4514fa15de7a80219f60bb8bee5c5dd84e303e523fa1c5d9b46 CHECKSUM(SHA256) upstream package : 76c542aa056bd4514fa15de7a80219f60bb8bee5c5dd84e303e523fa1c5d9b46 http://www.csie.ntu.edu.tw/~cjlin/liblinear/exp.html : CHECKSUM(SHA256) this package : 84b2ca3abffea689b3b6eb3b8f40e6c62b12f285f394630b9ade4dcb080bc48d CHECKSUM(SHA256) upstream package : 84b2ca3abffea689b3b6eb3b8f40e6c62b12f285f394630b9ade4dcb080bc48d http://www.csie.ntu.edu.tw/~cjlin/papers/liblinear.pdf : CHECKSUM(SHA256) this package : c2e0bfdbb5157aa7251b6d85a05aebeb3715dee2e9d74dc4bc336c5703011dec CHECKSUM(SHA256) upstream package : c2e0bfdbb5157aa7251b6d85a05aebeb3715dee2e9d74dc4bc336c5703011dec ##### Thanks for review, Christopher! ##### New Package SCM Request ======================= Package Name: liblinear Short Description: Library for Large Linear Classification Owners: besser82 Branches: el5 el6 f18 f19 InitialCC: Git done (by process-git-requests). liblinear-1.93-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/liblinear-1.93-2.fc19 liblinear-1.93-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/liblinear-1.93-2.fc18 liblinear-1.93-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/liblinear-1.93-2.el6 liblinear-1.93-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/liblinear-1.93-2.el5 liblinear-1.93-2.el5 has been pushed to the Fedora EPEL 5 testing repository. liblinear-1.93-2.fc19 has been pushed to the Fedora 19 stable repository. liblinear-1.93-2.fc18 has been pushed to the Fedora 18 stable repository. liblinear-1.93-2.el6 has been pushed to the Fedora EPEL 6 stable repository. liblinear-1.93-2.el5 has been pushed to the Fedora EPEL 5 stable repository. Package Change Request ====================== Package Name: liblinear Owners: ml-sig besser82 Branches: el5 el6 f18 f19 f20 Complete. |