Bug 996044

Summary: [Admin Portal] New VM ignores osinfo properties for network card, it is always VirtIO
Product: Red Hat Enterprise Virtualization Manager Reporter: Jiri Belka <jbelka>
Component: ovirt-engine-webadmin-portalAssignee: Lior Vernia <lvernia>
Status: CLOSED CURRENTRELEASE QA Contact: Martin Pavlik <mpavlik>
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: acathrow, bazulay, ecohen, gklein, iheim, lvernia, masayag, michal.skrivanek, mpavlik, myakove, nyechiel, Rhev-m-bugs, yeylon
Target Milestone: ---Keywords: EasyFix, Triaged
Target Release: 3.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: network
Fixed In Version: org.ovirt.engine-root-3.4.0-14 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine.log none

Description Jiri Belka 2013-08-12 09:50:44 UTC
Created attachment 785628 [details]
engine.log

Description of problem:
New VM dialog ignores osinfo properties for network card, it is always VirtIO.

Version-Release number of selected component (if applicable):
is9.1

How reproducible:
100%

Steps to Reproduce:
1. echo 'os.windows_xp.devices.network.value = e1000' > /etc/ovirt-engine/osinfo.conf.d/06-overridesectvalues.properties
2. /etc/init.d/ovirt-engine restart
3. New VM - Desktop - Windows XP
4. Check type of network adapter of the guest

Actual results:
VirtIO

Expected results:
e1000

Additional info:
it looks like this automatically added network card is always VirtIO.
check 'osinfo-test' in the log

Comment 1 Roy Golan 2014-02-17 10:31:44 UTC
UI Problem not osinfo
I'm checking that on 3.3 and the problem is a bit different - after confirming the new VM dialog, the VM is created but a canDo action popup rises following create vm interface command. 

Open the interfaces subtab and create a new interface and the UI and you'll see the dropdown is populated with virtio and e1000.

Lior?

Comment 2 Lior Vernia 2014-03-31 05:39:51 UTC
I'm not sure what's the "problem". Is the default type of vNIC supposed to be determined by osinfo? If so, I don't think this was ever implemented. If you create a new vNIC through the VM/interfaces subtab, you'll see that the default choice there is VirtIO as well, the only difference is that there's no widget to change that in the new VM dialog.

Comment 3 Roy Golan 2014-03-31 06:07:16 UTC
(In reply to Lior Vernia from comment #2)
> I'm not sure what's the "problem". Is the default type of vNIC supposed to
> be determined by osinfo? If so, I don't think this was ever implemented. If
> you create a new vNIC through the VM/interfaces subtab, you'll see that the
> default choice there is VirtIO as well, the only difference is that there's
> no widget to change that in the new VM dialog.

Its not only a default but rather the set of available values is determined by osinfo. so in this use-case virtio shouldn't be there at all

for some OS admin can determine virtio (PV) shouldn't be available

new vm dialog has this which should be fixed:

    protected void initSelectedType() {
        getNicType().setSelectedItem(AsyncDataProvider.getDefaultNicType());
    }

Comment 4 Martin Pavlik 2014-04-25 08:41:38 UTC
verified av7

VM NIC type is e1000

Comment 5 Itamar Heim 2014-06-12 14:11:39 UTC
Closing as part of 3.4.0