Bug 996942

Created attachment 786491 [details]
overflow

Created attachment 786492 [details]
"some drastiacally long comment, it just cannot be shortened."

A whole layout and styles refactor has been performed on GDT - Audit log widget.

	
Summary of changes performed:
============================
	- Changed base layout for the widget.
	- Move simple pager to page down area and centered.
	- Centered events container table.
	- Scroll only displayed on the event log entries area, not full widget.
	- Dropdown list for event types -> was already refactored in bug https://bugzilla.redhat.com/show_bug.cgi?id=996917
	- Removel Bootstrap Well component. Caused some layout problems.
	- Added title to event types.
	- Changes input text for comments to a text area and added helper placeholder with text "Insert your comments here..." (now user should know the textarea purpose for this input)
	- Each row has the event type fired in bold style.
	- Changed icon to bootstrap trash.

NOTES:
======
  - NOTE: Pending to refactor the layout of the audit log entries columns, but this will be performed in the resolution of https://bugzilla.redhat.com/show_bug.cgi?id=996944

  - NOTE: Added final screenshot of the audit log widget.
  - Tested in browsers:
		- Chrome 29.0.1547.65
		- FF 21.0
		- IE 10.0.9200
		- Safari 5.1.7

Commmits
========

- Master - https://github.com/droolsjbpm/drools-wb/commit/f406f3b7d46da8a9531d5cb50c2e02fea29a2d0c

- 6.0.x - https://github.com/droolsjbpm/drools-wb/commit/7e7a4ca80730f5ab030adb48e4a7048266d00a5f

Created attachment 815565 [details]
Final screenshot of the audit log widget (after this bug refactoring)

Final screenshot of the audit log widget (after this bug refactoring)

You've made some great improvements to this, thanks!

I'd still like to ask for a few more details though:

1. Your screenshot looked nice, but in ER5 I don't see the right edge of the comment input and the trash icon for deleting entries (FF 22).

2. In "Column updated" entry, there is "Columns Updated" presenting the individual changes (4th line, including the entry title)

3. For "Column updated" entries - some fields are mention with a colon (e.g. "Hide column:"), some without (e.g. "Header"). And in general, one log entry with 2 or more changes made to a column can take up a lot of space. Would it be possible to keep 1 change per line in the log entry? What I mean - right now, you can see this:

    Field name: Hide column:
    Old value: true
    New Value: false

    Field name: Field:
    Old value: a
    New Value: this

.. and so on. It might look better like this (while still in a list, formatted and indented as now):
    Hide column: true --> false
This would also make it look more like the "Column inserted" log entry (while still keeping it readable), where you use:
    Field:     a
    Operator:  ==
What do you think?

Hi Zuzana,

Agree with pending look&feel changes. 

Let me contact with Juanma Gonzalez (design&usability) for more details and I will close it as soon as possible.

Thanks!

Hi Zuzana,

As requested I have implemented these changes after discussing with Juanma (design&usability):
	- Textarea size fixed
	- Removed "Columns updated" literal for change events
	- Removed ":" after change event field name.
	- Changed field modified layout -> Ex: Default Value: "12" » "24"
	- Some other design tips

This BZ is related with https://bugzilla.redhat.com/show_bug.cgi?id=996932, so I have done the commits toghehter.

Please note that this fix will be available for next 6.0.X release.

Commits on master
=================

- drools -> https://github.com/droolsjbpm/drools/commit/7c62843d6ad6832f24fd4987307c230ccbdfa749

- drools-wb -> https://github.com/droolsjbpm/drools-wb/commit/64d985a565c02585c0771d2ea8669bb23eee8968

Commits on 6.0.X
================

- drools -> https://github.com/droolsjbpm/drools/commit/1da487614ddd0ee6699a3defd5cb3ff2df005558

- drools-wb -> https://github.com/droolsjbpm/drools-wb/commit/e76ffc10f9c3615aa6ce109e2f6ac597ae1a5b37

Verified with ER7.

I don't think the trash icon is even there, but that's quite unimportant. Great job - it looks so much better now.

Hi Zuzana!

I realised that depending on what user I was connected, the icon appeared or didn't.. so seems that the trash icon appears depending on the user roles, as far as I know :)

(In reply to Zuzana Krejčová from comment #12)
> Verified with ER7.
> 
> I don't think the trash icon is even there, but that's quite unimportant.
> Great job - it looks so much better now.

(In reply to Roger Martínez from comment #13)
> Hi Zuzana!
> 
> I realised that depending on what user I was connected, the icon appeared or
> didn't.. so seems that the trash icon appears depending on the user roles,
> as far as I know :)

Good catch. I've opened a new BZ for that - bug 1052939.