Bug 998109

NB RHEL 7 also requires the following commits:

https://github.com/libguestfs/libguestfs/commit/6f76fdb41eb6bd124fbc3d084f5c2a3371b37d9b
https://github.com/libguestfs/libguestfs/commit/46763bcc0b9d04ada367f29ca07bd3e11e264a8e

Turns out we need:
216cb004aef8ad6cb554ecdb9d7c4eb7634fe678
otherwise libvirt doesn't actually enable kvmclock.

libguestfs-1.22.6-12.el7
http://brewweb.devel.redhat.com/brew/taskinfo?taskID=6429251

Hi Rich,
I try to verify this bug with libguestfs-1.22.6-18.el7 according the steps recorded in https://bugzilla.redhat.com/show_bug.cgi?id=998108#c2 :

[root@rhel7libguestfs ~]# guestfish -x -v -N fs > boot.log 2>&1
[root@rhel7libguestfs ~]# cat boot.log | grep -Ei "kvmclock|kvm-clock"
libguestfs: libvirt XML:\n<?xml version="1.0"?>\n<domain type="kvm" xmlns:qemu="http://libvirt.org/schemas/domain/qemu/1.0">\n  <name>guestfs-m8wwuh1utchd0hnb</name>\n  <memory unit="MiB">500</memory>\n  <currentMemory unit="MiB">500</currentMemory>\n  <cpu mode="host-passthrough">\n    <model fallback="allow"/>\n  </cpu>\n  <vcpu>1</vcpu>\n  <clock offset="utc">\n    <timer name="kvmclock" present="yes"/>\n  </clock>\n  <os>\n    <type>hvm</type>\n    <kernel>/var/tmp/.guestfs-0/kernel.9501</kernel>\n    <initrd>/var/tmp/.guestfs-0/initrd.9501</initrd>\n    <cmdline>panic=1 console=ttyS0 udevtimeout=600 no_timer_check acpi=off printk.time=1 cgroup_disable=memory root=/dev/sdb selinux=0 guestfs_verbose=1 TERM=xterm</cmdline>\n  </os>\n  <on_reboot>destroy</on_reboot>\n  <devices>\n    <controller type="scsi" index="0" model="virtio-scsi"/>\n    <disk device="disk" type="file">\n      <source file="/root/test1.img"/>\n      <target dev="sda" bus="scsi"/>\n      <driver name="qemu" type="raw" cache="writeback"/>\n      <address type="drive" controller="0" bus="0" target="0" unit="0"/>\n    </disk>\n    <disk type="file" device="disk">\n      <source file="/tmp/libguestfsvzQGi1/snapshot1"/>\n      <target dev="sdb" bus="scsi"/>\n      <driver name="qemu" type="qcow2" cache="unsafe"/>\n      <address type="drive" controller="0" bus="0" target="1" unit="0"/>\n      <shareable/>\n    </disk>\n    <serial type="unix">\n      <source mode="connect" path="/tmp/libguestfsvzQGi1/console.sock"/>\n      <target port="0"/>\n    </serial>\n    <channel type="unix">\n      <source mode="connect" path="/tmp/libguestfsvzQGi1/guestfsd.sock"/>\n      <target type="virtio" name="org.libguestfs.channel.0"/>\n    </channel>\n  </devices>\n  <qemu:commandline>\n    <qemu:env name="TMPDIR" value="/var/tmp"/>\n  </qemu:commandline>\n</domain>\n

---------------------------------------------------------------------------------
But I can not find such lines in  boot.log:
"     -cpu host,+kvmclock \
    ...
    kvm-clock: Using msrs 4b564d01 and 4b564d00
    kvm-clock: cpu 0, msr 0:1c247c1, boot clock
    kvm-clock: cpu 0, msr 0:22167c1, primary cpu clock
    [    0.381003] Switching to clocksource kvm-clock
"'

Is there anything wrong with my steps? How can I make sure kvmclock is enabled in rhel7 and works well? 

Thanks and Best Regards,
Lingfei Kong

A few points:

(1) "-cpu host,+kvmclock" is NOT necessary to enable kvm-clock.
It is enabled by default for KVM guests.

(2) You SHOULD see:
    Switching to clocksource kvm-clock
during boot.

(3) If you are testing this inside a RHEL 7 VM, it won't work.  kvm-clock
is only enabled for KVM guests, not for TCG guests.

Do you see another clocksource mentioned in the output of
libguestfs-test-tool?

(In reply to Richard W.M. Jones from comment #6)
> A few points:
> 
> (1) "-cpu host,+kvmclock" is NOT necessary to enable kvm-clock.
> It is enabled by default for KVM guests.
> 
> (2) You SHOULD see:
>     Switching to clocksource kvm-clock
> during boot.
> 
> (3) If you are testing this inside a RHEL 7 VM, it won't work.  kvm-clock
> is only enabled for KVM guests, not for TCG guests.
> 
> Do you see another clocksource mentioned in the output of
> libguestfs-test-tool?

Thanks, Rich, saw the "Switching to clocksource kvm-clock"

# cat libguestfs-test-tool.log | grep kvm-clock
[    0.000000] kvm-clock: Using msrs 4b564d01 and 4b564d00
[    0.000000] kvm-clock: cpu 0, msr 0:1f071001, boot clock
[    0.000000] kvm-clock: cpu 0, msr 0:1f071001, primary cpu clock
[    0.377039] Switching to clocksource kvm-clock

Package version:
libguestfs-1.22.6-18.el7.x86_64
libvirt-1.1.1-19.el7.x86_64

So, verified this bug.

This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.