Bug 998303 (efreet)

*** Bug 890909 has been marked as a duplicate of this bug. ***

Scratch build for Rawhide fails:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5828485

From build.log (i686):

checking for doxygen... no
WARNING:
The doxygen program was not found in your execute path.
You may have doxygen installed somewhere not covered by your path.
If this is the case make sure you have the packages installed, AND
that the doxygen program is in your execute path (see your
shell manual page on setting the $PATH environment variable), OR
alternatively, specify the program to use with --with-doxygen.

...

/var/tmp/rpm-tmp.yBQpjB: line 37: chrpath: command not found
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.yBQpjB (%install)
    Bad exit status from /var/tmp/rpm-tmp.yBQpjB (%install)


Please add doxygen and chrpath to BuildRequires.

Another issue:
Requires:       %{name} = %{version}-%{release}
has to be
Requires:       %{name}%{?_isa} = %{version}-%{release}
because your package isn't noarch.

and, in addition to items mentioned already,

configure: error: Package requirements (ecore-file >= 1.7.8 ecore >= 1.7.8 eet >= 1.7.8 eina >= 1.7.8 ) were not met:

Requested 'ecore-file >= 1.7.8' but version of ecore-file is 1.7.7
Requested 'ecore >= 1.7.8' but version of ecore is 1.7.7
Requested 'eet >= 1.7.8' but version of eet is 1.7.7
Requested 'eina >= 1.7.8' but version of Eina is 1.7.7

MUST use versioned BuildRequires,
BuildRequires: ecore-devel >= %{version}

or (I know you don't like pkgconfig deps, but it tracks dependencies even closer):
BuildRequires: pkgconfig(ecore) >= %{version}

(the other deps are or should be pulled in by ecore-devel already)

Looks like I was wrong also need
BuildRequires: eet-devel >= %{version}
or
BuildRequires: pkgconfig(eet) >= %{version}

consider that last item 1, 

2. MUST use verbose build, do either
%configure ... --disable-silent-rules
or
make ... V=1

3.  MUST document what this is for (or remove it)
sed -i -e 's,${exec_prefix}/lib,%{_libdir},' configure

4. SHOULD, if not including documentation, use
%configure ... --disable-doc
(or add BuildRequires: doxygen 
as previously suggested)

5. SHOULD drop the rpath/chrpath hackery, not needed

6.  MUST document why these are omitted:
rm %{buildroot}%{_bindir}/%{name}_*
rm -r %{buildroot}%{_datadir}/%{name}/test/
(it would appear one reason is that they are just testsuite-like items)

7.  MUST update %changelog to reflect latest version (1.7.8)

Updated:

SPEC URL: http://vicodan.fedorapeople.org/vicodan.spec
SRPM URL: http://vicodan.fedorapeople.org/efreet-1.7.8-2.fc21.src.rpm

Updated:

SPEC URL: http://vicodan.fedorapeople.org/efreet.spec
SRPM URL: http://vicodan.fedorapeople.org/efreet-1.7.8-2.fc21.src.rpm

Updated:

SPEC URL: http://vicodan.fedorapeople.org/vicodan.spec
SRPM URL: http://vicodan.fedorapeople.org/efreet-1.7.8-3.fc21.src.rpm

Thanks, -3 looks good, APPROVED.

Updated:

SPEC URL: http://vicodan.fedorapeople.org/efreet.spec
SRPM URL: http://vicodan.fedorapeople.org/efreet-1.7.8-3.fc21.src.rpm

Package Change Request
======================
Package Name: emotion
New Branches: f19 f20
Owners: vicodan sundaram spot

Releng ticket filed:

https://fedorahosted.org/rel-eng/ticket/5750

Cleared flag.

Package Change Request
======================
Package Name: efreet
New Branches: f19 f20
Owners: vicodan sundaram spot

Releng ticket filed:

https://fedorahosted.org/rel-eng/ticket/5750

Git done (by process-git-requests).

Unretired, please take ownership of devel in pkgdb.

efreet-1.7.8-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/efreet-1.7.8-3.fc19

efreet-1.7.8-3.fc19 has been pushed to the Fedora 19 testing repository.

efreet-1.7.8-3.fc19 has been pushed to the Fedora 19 stable repository.