Bug 998459
| Summary: | Review Request: rubygem-paint - Terminal painter | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miroslav Suchý <msuchy> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jstribny, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-paint-0.8.6-3.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-05 01:27:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 998915 | ||
|
Description
Miroslav Suchý
2013-08-19 11:21:58 UTC
Taking. Taking. I will appreciate it if you would review one of my review requests (e.g. bug 912961 : note that bug 912961 depends on bug 912960 ) Some initial comments:
* MRI specfic Requires:
- Does "BuildRequires: ruby >= 1.8.7" mean that BR really
needs MRI ruby?
* Virtual (Build)Requires preferred
- Please use rubygem(rspec) instead of rubygem-rspec.
? Perhaps unneeded commands
- Please check if
cp -pr spec/ ./%{gem_instdir}
is really needed.
* Main documents
- At least "LICENSE.txt" should be main package, because
this contains license information
- Also I recommend to move "README.rdoc" to main, because
this is "README".
- _I_ would also move CHANGELOG.rdoc to main.
* Unwanted documents
- Files for test suite like spec/ should not be in
binary rpm: (see "Do not ship test" at below)
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites
- Also "Rakefile" is something like "Makefile" in
autotool-based packages and usually this is not needed
in binary rpm.
? Duplicate review request
- Please contact the submitter of bug 886871 .
*** Bug 886871 has been marked as a duplicate of this bug. *** > * MRI specfic Requires: Not needed, I was specified in gemspec. And it seems that author just wanted to say ruby higher the 1.8. And since that is valid on all current Fedoras, plain Requires: ruby(release) is enough. > * Virtual (Build)Requires preferred Fixed. > ? Perhaps unneeded commands It works without that as well. Hmm, why I added that? Could not recall. Removing. > * Main documents I moved LICENSE and README. I choosed to keep CHANGELOG in -doc. > * Unwanted documents Those test are not in main package (this is what Guideliness are saying). They are presented in -doc subpackage (which does all other rubygems package as well). This is IMO good as test are in fact often good examples how to use that library. The same for Rakefile. > Please contact the submitter of bug 886871. Aha, did not noticed that. Jstribrny sits in the same cubicle as me, I will tell him as soon as hi appear in office. Closing bug 886871 as duplicate. Spec URL: http://miroslav.suchy.cz/fedora/rubygem-paint/rubygem-paint.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-paint/rubygem-paint-0.8.6-3.fc19.src.rpm Is http://miroslav.suchy.cz/ alive? > Aha, did not noticed that.
Not a problem, continue with the packaging of this gem.
Josef
(In reply to Mamoru TASAKA from comment #6) > Is http://miroslav.suchy.cz/ alive? Now it seems alive. Approving. ----------------------------------------------------------- This package (rubygem-paint) is APPROVED by mtasaka ------------------------------------------------------------ Thanks. New Package SCM Request ======================= Package Name: rubygem-paint Short Description: Terminal painter Owners: msuchy Branches: f19 f20 InitialCC: Git done (by process-git-requests). rubygem-paint-0.8.6-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-paint-0.8.6-3.fc19 rubygem-paint-0.8.6-3.fc19 has been pushed to the Fedora 19 testing repository. rubygem-paint-0.8.6-3.fc19 has been pushed to the Fedora 19 stable repository. |