Bug 998732
| Summary: | [abrt] kernel BUG at drivers/iommu/intel-iommu.c:785! | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Julian Stecklina <js> | ||||||
| Component: | kernel | Assignee: | Kernel Maintainer List <kernel-maint> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 19 | CC: | alex.williamson, gansalmon, itamar, jonathan, kernel-maint, madhu.chinakonda | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | x86_64 | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | abrt_hash:8d7b233cf713c12e06882104eae5b2e92563023b | ||||||||
| Fixed In Version: | kernel-3.11.4-101.fc18 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-10-13 19:55:43 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Julian Stecklina
2013-08-19 23:31:54 UTC
Created attachment 788211 [details]
File: dmesg
This also happens for page size mappings. I think it is the first mapping of DMA memory above 4G in my program. Ok, I checked the capabilities register of the IOMMU and the MGAW (maximum guest address width) seems to be 38. Thus VFIO asks the IOMMU about addresses the latter cannot handle, which is probably what the BUG_ON tests for. This is bad, because the user can control the addresses and force the kernel to stumble over a BUG_ON. In intel_iommu_map() this case is handled explicitly. Created attachment 788499 [details]
Fix pfn_to_dma_pte to return NULL instead of tripping over BUG_ON.
With the attached patch a program using VFIO will get an EFAULT from the corresponding ioctl call and a helpful message in the kernel log (from intel_iommu_map).
I created an upstream bug: https://bugzilla.kernel.org/show_bug.cgi?id=60777 (In reply to Julian Stecklina from comment #5) > I created an upstream bug: https://bugzilla.kernel.org/show_bug.cgi?id=60777 Did you send this to the upstream maintainers? Not everyone pays attention to kernel.org bugzilla, so it's likely best to email them the patch directly. Will do. *********** MASS BUG UPDATE ************** We apologize for the inconvenience. There is a large number of bugs to go through and several of them have gone stale. Due to this, we are doing a mass bug update across all of the Fedora 19 kernel bugs. Fedora 19 has now been rebased to 3.11.1-200.fc19. Please test this kernel update and let us know if you issue has been resolved or if it is still present with the newer kernel. If you experience different issues, please open a new bug report for those. (In reply to Julian Stecklina from comment #7) > Will do. Did you send this upstream then? I don't see it in Linus' tree or in my lkml archives. See http://lists.linuxfoundation.org/pipermail/iommu/2013-August/006411.html I'll resubmit the patch. (In reply to Julian Stecklina from comment #10) > See http://lists.linuxfoundation.org/pipermail/iommu/2013-August/006411.html > > I'll resubmit the patch. Great, thanks for the pointer. I see that it has at least one upstream Ack, so I'll grab it for the next Fedora build as well. Added across the Fedora releases. Thanks again. kernel-3.11.4-201.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/kernel-3.11.4-201.fc19 kernel-3.11.4-101.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kernel-3.11.4-101.fc18 kernel-3.11.4-301.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/kernel-3.11.4-301.fc20 Package kernel-3.11.4-201.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing kernel-3.11.4-201.fc19' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-18820/kernel-3.11.4-201.fc19 then log in and leave karma (feedback). kernel-3.11.4-301.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. kernel-3.11.4-201.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. kernel-3.11.4-201.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. kernel-3.11.4-101.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. |