Bug 998791
Summary: | quota: posix compliace test fails | ||||||
---|---|---|---|---|---|---|---|
Product: | [Red Hat Storage] Red Hat Gluster Storage | Reporter: | Saurabh <saujain> | ||||
Component: | quota | Assignee: | Vijaikumar Mallikarjuna <vmallika> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Saurabh <saujain> | ||||
Severity: | high | Docs Contact: | |||||
Priority: | high | ||||||
Version: | 2.1 | CC: | asriram, gluster-bugs, grajaiya, mhideo, mselvaga, mzywusko, rabhat, rhs-bugs, rwheeler, sdharane, shmohan, smohan, storage-doc, storage-qa-internal, vagarwal, vbellur, vmallika | ||||
Target Milestone: | --- | Keywords: | ZStream | ||||
Target Release: | --- | ||||||
Hardware: | x86_64 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: |
During a file rename operation, if the hashing logic moves the target file to a different brick, then the rename operation fails if it is initiated by a non-root user.
|
Story Points: | --- | ||||
Clone Of: | Environment: | ||||||
Last Closed: | 2015-10-26 08:30:32 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 1020127 | ||||||
Attachments: |
|
Description
Saurabh
2013-08-20 05:38:42 UTC
Created attachment 788307 [details]
nfs logs
Are the brick machines in sync with the time? /opt/qa/tools/pjd-fstest-20080816/tests/mkfifo/00.t (Wstat: 0 Tests: 36 Failed: 5) Failed tests: 30-34 /opt/qa/tools/pjd-fstest-20080816/tests/symlink/00.t (Wstat: 0 Tests: 14 Failed: 2) Failed tests: 11-12 The above failures might be because of out of sync time between the brick machines (it happens even without quota and on fuse mount also). For rename and unlink related issues, a patch has been sent for the review (http://review.gluster.org/#/c/5668/). Also on nfs some posix compliance tests are known to failure. So please make sure, the failed tests are not just them. https://code.engineering.redhat.com/gerrit/11621 handles the issue. https://code.engineering.redhat.com/gerrit/12179 rhs-2.1 patch fixes the issue. "Fixed in version" please. By running posix-complaince tests i could see some extra test failures with quota. prove -r /opt/qa/tools/posix-testsuite/tests/ without quota ------- Test Summary Report ------------------- /opt/qa/tools/posix-testsuite/tests/chown/00.t (Wstat: 0 Tests: 171 Failed: 3) Failed tests: 77, 84, 88 /opt/qa/tools/posix-testsuite/tests/rename/05.t (Wstat: 0 Tests: 17 Failed: 5) Failed tests: 10, 12, 14, 16-17 Files=185, Tests=1962, 92 wallclock secs ( 1.19 usr 0.44 sys + 10.40 cusr 10.63 csys = 22.66 CPU) Result: FAIL with quota ------------- Test Summary Report ------------------- /opt/qa/tools/posix-testsuite/tests/chown/00.t (Wstat: 0 Tests: 171 Failed: 3) Failed tests: 77, 84, 88 /opt/qa/tools/posix-testsuite/tests/rename/00.t (Wstat: 0 Tests: 79 Failed: 4) Failed tests: 64-65, 68, 79 /opt/qa/tools/posix-testsuite/tests/rename/05.t (Wstat: 0 Tests: 17 Failed: 5) Failed tests: 10, 12, 14, 16-17 Files=185, Tests=1962, 93 wallclock secs ( 1.19 usr 0.44 sys + 10.50 cusr 10.67 csys = 22.80 CPU) Result: FAIL This test was run on NFS mount NFS logs -------- [2013-10-06 13:28:23.305071] W [client-rpc-fops.c:638:client3_3_unlink_cbk] 0-dr-client-2: remote operation failed: Permission denied [2013-10-06 13:28:23.305183] W [client-rpc-fops.c:638:client3_3_unlink_cbk] 0-dr-client-3: remote operation failed: Permission denied [2013-10-06 13:28:23.305228] W [dht-rename.c:365:dht_rename_unlink_cbk] 0-dr-dht: /fstest_d9762303927458ebbc17aef634371c88/fstest_eb61a05a4a) [2013-10-06 13:28:25.388261] W [client-rpc-fops.c:638:client3_3_unlink_cbk] 0-dr-client-4: remote operation failed: Permission denied [2013-10-06 13:28:25.388349] W [client-rpc-fops.c:638:client3_3_unlink_cbk] 0-dr-client-5: remote operation failed: Permission denied [2013-10-06 13:28:25.388386] W [nfs3.c:3663:nfs3svc_rename_cbk] 0-nfs: a85a9972: rename /fstest_d9762303927458ebbc17aef634371c88/fstest_eb61) [2013-10-06 13:28:26.429227] W [client-rpc-fops.c:638:client3_3_unlink_cbk] 0-dr-client-4: remote operation failed: Permission denied [2013-10-06 13:28:26.429306] W [client-rpc-fops.c:638:client3_3_unlink_cbk] 0-dr-client-5: remote operation failed: Permission denied [2013-10-06 13:28:26.429341] W [nfs3.c:3663:nfs3svc_rename_cbk] 0-nfs: b15a9972: rename /fstest_d9762303927458ebbc17aef634371c88/fstest_eb61) [2013-10-06 13:28:26.458371] W [nfs3.c:3508:nfs3svc_rmdir_cbk] 0-nfs: b75a9972: /fstest_d9762303927458ebbc17aef634371c88 => -1 (Directory no) [2013-10-06 13:28:28.162879] W [nfs3.c:3508:nfs3svc_rmdir_cbk] 0-nfs: f75b9972: /fstest_0880cd50fc83aaafc68da6e61f8edd80/fstest_3ed6b6a07947) [2013-10-06 13:28:28.174497] W [nfs3.c:3508:nfs3svc_rmdir_cbk] 0-nfs: fa5b9972: /fstest_0880cd50fc83aaafc68da6e61f8edd80 => -1 (Directory no) [2013-10-06 13:28:32.489394] W [nfs3.c:3663:nfs3svc_rename_cbk] 0-nfs: fe5d9972: rename /fstest_a5ac720430f17a8c6af3a085567f7439 -> /fstest_) [2013-10-06 13:28:32.489471] W [nfs3-helpers.c:3391:nfs3_log_common_res] 0-nfs-nfsv3: XID: fe5d9972, RENAME: NFS: 66(Directory not empty), P) [2013-10-06 13:28:32.524794] W [nfs3.c:3663:nfs3svc_rename_cbk] 0-nfs: 85e9972: rename /fstest_a5ac720430f17a8c6af3a085567f7439 -> /fstest_b) [2013-10-06 13:28:32.524852] W [nfs3-helpers.c:3391:nfs3_log_common_res] 0-nfs-nfsv3: XID: 85e9972, RENAME: NFS: 66(Directory not empty), PO) [2013-10-06 13:28:32.563173] W [nfs3.c:3663:nfs3svc_rename_cbk] 0-nfs: 125e9972: rename /fstest_a5ac720430f17a8c6af3a085567f7439 -> /fstest_) [2013-10-06 13:28:32.563247] W [nfs3-helpers.c:3391:nfs3_log_common_res] 0-nfs-nfsv3: XID: 125e9972, RENAME: NFS: 66(Directory not empty), P) [2013-10-06 13:28:32.594655] W [nfs3.c:3663:nfs3svc_rename_cbk] 0-nfs: 1b5e9972: rename /fstest_a5ac720430f17a8c6af3a085567f7439 -> /fstest_) [2013-10-06 13:28:32.594712] W [nfs3-helpers.c:3391:nfs3_log_common_res] 0-nfs-nfsv3: XID: 1b5e9972, RENAME: NFS: 66(Directory not empty), P) This failure is because, when rename happens, distribute splits the call in to separate calls (mknod of the linkfile, link new name, unlink oldname). So the rename call as a whole does not go through the posix acl xlator thus preventing some of the checks for rename from happening. I think this fail happens only on nfs client. (Can you pleas check if it happens on fuse client?) Its because when tests are done on the fuse mount point, before the rename call comes to glusterfs, the acl check is done by the kernel itself and appropriate error is sent to the application (if the rename call is not allowed). Unfortunately for nfs client the kernel does not do acl checks and sends the call to glusterfs which when comes to distribute xlator gets split into multiple calls (as explained in above paragraph) thus preventing actual acl check for the rename. Loading a posix-acl xlator below nfs xlator in the nfs-server volfile solves the issue (But I am not sure whether loading the posix-acl xlator below nfs xlator is a good idea). Moving the known issues to Doc team, to be documented in release notes for U1 Moving the known issues to Doc team, to be documented in release notes for U1 Moving the known issues to Doc team, to be documented in release notes for U1 I've documented this known issue in the BB U1 Release Notes. Here is the link: http://documentation-devel.engineering.redhat.com/docs/en-US/Red_Hat_Storage/2.1/html/2.1_Update_1_Release_Notes/chap-Documentation-2.1_Update_1_Release_Notes-Known_Issues.html Patch submitted upstream: http://review.gluster.org/#/c/9419/ The above mentioned test cases are passing in 3.7 on a fuse mount. So, closing the bug. |