Bug 999052

Summary:	Review Request: perl-WWW-Splunk - Client library for Splunk log search engine
Product:	[Fedora] Fedora	Reporter:	Lubomir Rintel <lkundrak>
Component:	Package Review	Assignee:	Ralf Corsepius <rc040203>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	notting, rc040203
Target Milestone:	---	Flags:	rc040203: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-09-25 21:17:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lubomir Rintel 2013-08-20 15:42:08 UTC

SPEC: http://v3.sk/~lkundrak/SPECS/perl-WWW-Splunk.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/perl-WWW-Splunk-2.04-1.el6.src.rpm

Description:

WWW::Splunk is a client for Splunk log search engine. It consists of a utility 
with command-line interface, sc, and a supporting library. It lets you query 
the archived logs or conduct a real-time search.

Comment 1 Ralf Corsepius 2013-08-21 04:53:10 UTC

Basically OK, but these items:

1. Please remove these Requires:
Requires:       perl(Date::Manip)
Requires:       perl(HTTP::Request::Common)
Requires:       perl(LWP::UserAgent)
Requires:       perl(Test::More)
Requires:       perl(Text::CSV)   
Requires:       perl(XML::LibXML)

Modern rpm tracks run-time perl-module requirements automatically, which reduces the packager's work-load and helps avoiding packaging mistakes.
e.g. The R: perl(Test::More) above is incorrect. It's not a run-time requirement, but only a testsuite's requirement.

2. Consider to remove the rpm anachronisms from your spec (rm -rf RPM_BUILD_ROOT, BuildRoot, defattr(), %clean ...).

I understand, your target distro is epel6, but even there most of them are not needed anymore (AFAICT, they are still needed on epel5).

Comment 2 Lubomir Rintel 2013-09-19 14:38:41 UTC

Thank you for your review.

I prefer to keep the obsolete constructs in package as I like the same package to be buildable for el5 as well, unless you object it very strongly.

Here's the updated package:

SPEC: http://v3.sk/~lkundrak/SPECS/perl-WWW-Splunk.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/perl-WWW-Splunk-2.04-2.el6.src.rpm

Comment 3 Ralf Corsepius 2013-09-20 06:43:45 UTC

Something weird:

man sc on rawhide gives:
...
       The code is hosted on GitHub <http://github.com/lkundrak/perl-WWW-Splunk>.  Bug fixes and feature enhancements are always welcome.

POD ERRORS
       Hey! The above document had some coding errors, which are explained below:

       Around line 214:
           Unterminated B<...> sequence

...

Apparently pod2man encounters an error and encodes this into generated man-page
From /usr/share/man/man1/sc.1:
...
.SH "POD ERRORS"
.IX Header "POD ERRORS"
Hey! \fBThe above document had some coding errors, which are explained below:\fR
.IP "Around line 214:" 4
.IX Item "Around line 214:"  
Unterminated B<...> sequence
...

Comment 4 Lubomir Rintel 2013-09-23 06:37:39 UTC

Thank you for noticing this! An updated version is on its way to CPAN.

SPEC: http://v3.sk/~lkundrak/SPECS/perl-WWW-Splunk.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/perl-WWW-Splunk-2.05-1.el6.src.rpm

Comment 5 Ralf Corsepius 2013-09-25 11:38:18 UTC

APPROVED

Clean package - Nothing much to say about

Comment 6 Lubomir Rintel 2013-09-25 19:10:44 UTC

Thank you Ralf!

New Package SCM Request
=======================
Package Name: perl-WWW-Splunk
Short Description: Client library for Splunk log search engine
Owners: lkundrak
Branches: f18 f19 f20 el6 el6

Comment 7 Gwyn Ciesla 2013-09-25 19:24:49 UTC

Git done (by process-git-requests).

Comment 8 Lubomir Rintel 2013-09-25 21:17:59 UTC

Imported and built.
Thanks Jon and Ralf!