Bug 999259

Summary:	Clean up Build.PL
Product:	[Community] Publican	Reporter:	Jeff Fearn 🐞 <jfearn>
Component:	publican	Assignee:	Jeff Fearn 🐞 <jfearn>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.1	CC:	aigao, rlandman
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	4.0.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-12-19 02:46:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeff Fearn 🐞 2013-08-21 03:40:36 UTC

Build.PL has build requires that can't be determined running `perl Build.PL` this needs to be changed so it works properly.

e.g. if you don't have File::pushd installed you can't run the install_deps target.

Comment 2 HSS Product Manager 2013-09-23 06:47:51 UTC

HSS-QE has reviewed and declined this request. QE for this bug will be handled by IED.

Comment 3 Jeff Fearn 🐞 2013-09-23 23:16:02 UTC

Reworked includes so that deps can bet installed properly from scratch.

To ssh://git.fedorahosted.org/git/publican.git
   87804ea..6347b27  HEAD -> devel

Comment 4 Ruediger Landmann 2013-10-11 03:44:26 UTC

Verified in publican-3.9.9-0.fc19.t4.noarch

perl Build.PL fails immediately if File::pushd isn't installed:

Can't locate File/pushd.pm in @INC

Comment 5 Jeff Fearn 🐞 2013-10-11 03:55:50 UTC

(In reply to Ruediger Landmann from comment #4)
> Verified in publican-3.9.9-0.fc19.t4.noarch
> 
> perl Build.PL fails immediately if File::pushd isn't installed:
> 
> Can't locate File/pushd.pm in @INC

This describes the original problem, it should not die like this. It should give the "missing dep" message and ask you to install them.

Comment 6 Jeff Fearn 🐞 2013-10-11 06:40:18 UTC

To ssh://git.fedorahosted.org/git/publican.git
   f158668..3384a72  HEAD -> devel

Comment 7 Ruediger Landmann 2013-10-11 06:57:43 UTC

OK, it now reports:

$ perl Build.PL
Checking prerequisites...
  requires:
    !  File::pushd is not installed
  build_requires:
    !  File::pushd is not installed

ERRORS/WARNINGS FOUND IN PREREQUISITES.  You may wish to install the versions
of the modules indicated above before proceeding with this installation

Run 'Build installdeps' to install missing prerequisites.