Bug 999297
| Summary: | Username/Password not stored with smbspool backend | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcus Moeller <marcus.moeller> |
| Component: | system-config-printer | Assignee: | Tim Waugh <twaugh> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 19 | CC: | aheinecke, collura, jpopelka, matteo, rhbgs.10.bigi_gigi, twaugh |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | system-config-printer-1.4.4-1.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-03-30 06:03:24 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Marcus Moeller
2013-08-21 06:12:52 UTC
Created attachment 814931 [details]
Fix to actually request authentication information.
Currently the Gnome Keyring is only used to store / retrive authentication information if the jobviewer is run as an applet and not if it is run directory from system-config-printer. The explicit "Authenticate Job" menu entry also ignores the keyring.
Additionally the support gnome keyring integration in applet mode is not working since the GIR conversion (68a307f) as there were slight API changes and the actual call to add credentials to the keyring still used the old module name which is no longer imported.
This was probably not noticed because the check if authentication should be requested used the wrong key and thus never asked for authentication.
I'm attaching patches to fix the usage of gnome-keyring in applet mode. The next step to improve this issue would then be to also use gnome keyring when running standalone and when "Authenticate Job" is requested from the menu.
Created attachment 814932 [details]
Fix to retrive items from the keyring
Created attachment 814934 [details]
Adapt usage of new API
This is the last patch in this series.
Tested on a Fedora 19 System
Please let me know if you prefer another form of the patches.
Thanks very much! Applied. system-config-printer-1.4.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/system-config-printer-1.4.3-1.fc20 system-config-printer-1.4.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/system-config-printer-1.4.3-1.fc19 Package system-config-printer-1.4.3-1.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing system-config-printer-1.4.3-1.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-19726/system-config-printer-1.4.3-1.fc19 then log in and leave karma (feedback). @Tim, please note that the patchset is only an initial step and a few more have to follow. Could you please add python-smbc as dependency as otherwise I got a NameError: global name 'pysmb' is not defined Thanks, noted. 'pysmb' is part of system-config-printer-libs, so if you're seeing that error it indicates a problem within system-config-printer rather than a missing dependency. Could you please file a separate bug report if you can reproduce it? Thanks. At least installing python-smbc solved the problem. Wonder if you're talking about the issue I just fixed upstream in commit 55c2eb5? python-smbc is deliberately not required by system-config-printer (see bug #921132). system-config-printer-1.4.3-2.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. re-opening: As commented earlier, the patchset is only an initial step to fix the problem, I have reported. system-config-printer-1.4.3-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. I've prepared patches to also fix saving the credentials when the jobviewer is not run as an applet and you manually select "authenticate" from the menu. Previously this would just show the authenticate dialog and forget the credentials even if you checked "remember password". Patch 1 factors out the keyring lookup from update-job into its own function so that it can be reused. Patch 2 enables update-job to silently look in the keyring (without showing the authenticate dialog) when it is not run as an applet. So that remember password works also in that mode. Patch 3 Adds the keyring usage to authenticate job when called directly from the menu. I think this should fix all problems mentioned in this report. Created attachment 830534 [details] 0001-Factor-out-username-password-lookup-for-reuse This is the first patch mentioned in Comment 15 Created attachment 830535 [details] 0002-Add-show_dialog-option-to-get_authentication This is the second patch mentioned in comment 15 Created attachment 830537 [details] 0003-Use-keyring-authentication-also-from-menu This is the third and final patch mentioned in comment 15 Thank you very much! Applied upstream. system-config-printer-1.4.4-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/system-config-printer-1.4.4-1.fc20 Package system-config-printer-1.4.4-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing system-config-printer-1.4.4-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-4014/system-config-printer-1.4.4-1.fc20 then log in and leave karma (feedback). system-config-printer-1.4.4-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |