Bug 999330

Summary: Review Request: snifflib - Numerical library for Java
Product: [Fedora] Fedora Reporter: Michael Simacek <msimacek>
Component: Package ReviewAssignee: Mikolaj Izdebski <mizdebsk>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mizdebsk, mray271, notting
Target Milestone: ---Flags: mizdebsk: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-08-23 17:09:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Michael Simacek 2013-08-21 07:45:24 UTC
Spec URL: http://msimacek.fedorapeople.org/snifflib.spec
SRPM URL: http://msimacek.fedorapeople.org/snifflib-1.8.10-1.fc19.src.rpm
Description: The Snifflib numerical library provides honest-to-goodness N-dimensional array construction and manipulation along with standard linear algebra functionality as well as statistics and computational routines in the JAVA language.
Fedora Account System Username: msimacek
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5835776

Comment 1 Mikolaj Izdebski 2013-08-21 07:52:33 UTC
*** Bug 983784 has been marked as a duplicate of this bug. ***

Comment 2 Mikolaj Izdebski 2013-08-21 08:03:38 UTC
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5835787

Sources: generate-tarball.sh doesn't need to be included as source (not a blocker), besides that OK.
Patches OK.
Licensing OK.
Requires OK.
No bundled JARs.

Rpmlint:
snifflib.noarch: E: incorrect-fsf-address /usr/share/doc/snifflib/LGPLv3.txt
myrtle.noarch: W: no-documentation
myrtle.noarch: W: no-manual-page-for-binary myrtle
snifflib-javadoc.noarch: E: incorrect-fsf-address /usr/share/doc/snifflib-javadoc/LGPLv3.txt
3 packages and 0 specfiles checked; 2 errors, 2 warnings.

Blocker issue: You need to update desktop and icon caches after installing desktop and icon files. See http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

Comment 3 Michael Simacek 2013-08-21 08:27:49 UTC
Added scriptlets for updating caches
SPEC: http://msimacek.fedorapeople.org/snifflib.spec
SRPM: http://msimacek.fedorapeople.org/snifflib-1.8.10-2.fc19.src.rpm

Comment 5 Mikolaj Izdebski 2013-08-21 09:18:37 UTC
Approved.

Comment 6 Michael Simacek 2013-08-21 09:31:46 UTC
New Package SCM Request
=======================
Package Name: snifflib
Short Description: Numerical library for Java
Owners: msimacek mizdebsk sochotnicky msrb
Branches: f19
InitialCC:

Comment 7 Michael Simacek 2013-08-21 10:36:17 UTC
New Package SCM Request
=======================
Package Name: snifflib
Short Description: Numerical library for Java
Owners: msimacek mizdebsk sochotni msrb
Branches: f19
InitialCC: java-sig

Comment 8 mray271 2013-08-21 16:00:32 UTC

Man page for Myrtle has now been added upstream.  See doc/man/myrtle.1 

Tagged under snifflib release 1.8.12

Comment 9 Mikolaj Izdebski 2013-08-21 16:02:35 UTC
(In reply to mray271 from comment #8)
> 
> Man page for Myrtle has now been added upstream.  See doc/man/myrtle.1 
> 
> Tagged under snifflib release 1.8.12

Thank you.  We'll add the manpage in future versions of the package.

Comment 10 Gwyn Ciesla 2013-08-22 12:33:02 UTC
Git done (by process-git-requests).

Comment 11 Mikolaj Izdebski 2013-08-23 17:09:25 UTC
Package built, closing.