Bug 999671

Summary: EAP62_2010 - [RFE] Logging Unification (JGroups)
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: Brian Stansberry <brian.stansberry>
Component: ClusteringAssignee: Paul Ferraro <paul.ferraro>
Status: CLOSED EOL QA Contact: Michal Vinkler <mvinkler>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.1.0CC: bban, jdoyle, jkudrnac, myarboro, nziakova, pkremens, rhusar
Target Milestone: ---   
Target Release: TBD EAP 7   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-19 12:45:03 UTC Type: Enhancement
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1003107    
Bug Blocks:    
Attachments:
Description Flags
JGroups serious logs without id - JGroups-3.2.12.Final none

Description Brian Stansberry 2013-08-21 20:01:40 UTC
Tracker issue for JGroups portion of EAP62_2010 Logging Unification.

ANDIAMO-7 compliance.

Comment 1 Paul Ferraro 2013-08-30 15:17:49 UTC
https://github.com/belaban/JGroups/pull/101
This PR updates the message formats used in JGroups to match those used in EAP.

Will require JGroups 3.2.11.Final release.

N.B. EAP already configures JGroups with a custom Log implemented by JBoss Logging, so the resulting log messages will have a consistent format.

Comment 2 Paul Ferraro 2013-09-03 15:35:54 UTC
PR for component upgrade:
https://github.com/jbossas/jboss-eap/pull/346

Comment 3 Petr Kremensky 2013-09-18 14:02:09 UTC
Created attachment 799394 [details]
JGroups serious logs without id - JGroups-3.2.12.Final

Comment 4 Petr Kremensky 2013-09-18 14:04:16 UTC
Per ANDIAMO-7 every serious log message (warn, error, fatal) should have a unique code that can be used to identify it. 

But I found 525 serious log messages without id: see attachment 799394 [details]

Comment 5 Paul Ferraro 2013-09-26 15:26:33 UTC
Many of these log messages are used in tests or demos.
Many are also assertions - and are not triggered at runtime.

Comment 6 Bela Ban 2013-09-30 09:37:54 UTC
JGroups JIRA: https://issues.jboss.org/browse/JGRP-1709

Comment 7 Bela Ban 2013-10-02 14:29:55 UTC
Most of the ERROR and WARN messages in the attached log are from 
- classes that are not officially supported (STOMP, PRIO)
- classes that are not used anymore (e.g. NAKACK, NakReceiverWindow, Retransmitter, DefaultRetransmitter, RangeBasedRetransmitter etc)
- test code (StateTransferTest)
- demos (Whiteboard, GraphPanel, Draw, QuoteServer)

What would be much more useful is to have a list of ERROR and WARN messages that are actually logged running the testsuite and from support cases in production. These could then successively be converted to use unique message IDs.

Comment 9 Petr Kremensky 2013-10-07 06:30:59 UTC
Unfortunately we don't have such a list and getting this would take great effort. All we can do is to update our tests to ignore test classes, demos and all classes you mentioned.

Comment 12 Paul Ferraro 2013-10-16 12:11:29 UTC
The remaining log messages will have to be addressed in a future release.

Comment 14 Paul Ferraro 2013-11-22 22:36:43 UTC
Rescheduling this for EAP7.  According to Bela, this won't be fully addressed until JGroups 3.5 or so.