| Summary: | [Usability] Cancel operation is ignored when flushing JMS destination metrics in the management console | ||
|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise Application Platform 6 | Reporter: | Osamu Nagano <onagano> |
| Component: | Web Console | Assignee: | Harald Pehl <hpehl> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Jakub Cechacek <jcechace> |
| Severity: | high | Docs Contact: | Russell Dickenson <rdickens> |
| Priority: | unspecified | ||
| Version: | 6.1.0 | CC: | hpehl, jkudrnac, mvelas, myarboro, smumford |
| Target Milestone: | ER9 | ||
| Target Release: | EAP 6.3.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
In JBoss EAP 6.1.0 and 6.1.1, before flushing a JMS destination via the web management console, a confirmation dialog was shown, requesting confirmation of the action. Regardless of the user's reply, the JMS destination *was* flushed. The root cause of this issue was that the result of the confirmation prompt was ignored. This issue has now been resolved and the JMS destination is only flushed if the confirmation dialog was closed with "OK".
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-08-06 14:37:17 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1003533 | ||
|
Description
Osamu Nagano
2013-08-22 07:48:44 UTC
Osamu Nagano <onagano> made a comment on jira WFLY-1921 {{isConfirmed}} is ignored in the {{onConfirmation()}} method. The same in {{TopicMetrics.java}}. [https://github.com/jbossas/console/blob/develop/gui/src/main/java/org/jboss/as/console/client/shared/runtime/jms/QueueMetrics.java#L180] {code:java} 176 Feedback.confirm("Flush Queue", "Do you really want to flush queue "+queue.getName(), 177 new Feedback.ConfirmationHandler(){ 178 @Override 179 public void onConfirmation(boolean isConfirmed) { 180 presenter.onFlushQueue(queue); 181 } 182 }); {code} This bug can be critical, a message lost, but easy to fix. Shouldn't we rush this into EAP 6.1.1? I seriously doubt that lack of confirmation dialog is critical. It is certainly confusing and thus should be properly documented. 6.1.1 is in ER8 should go straight to GA. I will propose this fix to 6.2.0 If you would have decided to perform this operation from let's say CLI, you would have to do so without confirmation message. Another workaround would bo to close configrmation dialog with the X button in upport right corner. I agree with Jakub, I would consider this to be a critical bug. meant to say: ... would not Confirmation dialog is still broken. This is an important usability issue promised to be addressed in 6.2.0. Thus setting higher severity and proposing a blocker. I apologize for last comment. The verification was done against ER2. The issue as described in this report is fixed in ER3 (hal 2.0.0.Final) Verified 6.2.0.ER3 Harald Pehl <hpehl> updated the status of jira WFLY-1921 to Resolved Harald Pehl <hpehl> made a comment on jira WFLY-1921 Fixed in upstream. Will be part of WF 8 and EAP 6.2.CP0a. Was this functionality removed in EAP 6.3.0 from webconsole? There is no such option in Configuraion > Messaging > Destinations > Queues. Verified for EAP 6.3.0.ER9 (messages are flushed only when Flush is Confirmed). Making public for inclusion in 6.3.0 Release Notes. |