Bug 999964
| Summary: | Unclear completion message in engine-setup esp for upgrades | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Andrew Cathrow <acathrow> |
| Component: | ovirt-engine-setup | Assignee: | Alon Bar-Lev <alonbl> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | movciari |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.3.0 | CC: | acathrow, alonbl, bazulay, iheim, rbalakri, Rhev-m-bugs, yeylon |
| Target Milestone: | --- | ||
| Target Release: | 3.3.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | integration | ||
| Fixed In Version: | is12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-01-21 22:19:24 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Andrew Cathrow
2013-08-22 13:15:25 UTC
(In reply to Andrew Cathrow from comment #0) > At the end of an upgrade running engine-setup the last message is > > "[ INFO ] Stage: Termination" > > It's not clear what that means. > I understand what this means, but a customer may believe this is a failure. > We can fix this simply by adding an extra INFO messaging saying that > upgrade/setup completed successfully The same infrastructure is used for host-deploy, host-rename, engine-clean, hosted-engine and of course engine setup and upgrade. This is the last stage of sequence (well apart of reboot), we can display any label you want but it should be generic and at the framework we do not actually know what we are used for. Forgot to mention that this stage is executed regardless of success/failure. (In reply to Alon Bar-Lev from comment #2) > Forgot to mention that this stage is executed regardless of success/failure. Can we display something like "operation completed successfully" ? Ideally we would replace operation with the appropriate use (upgrade, etc) - is that possible? (In reply to Andrew Cathrow from comment #3) > (In reply to Alon Bar-Lev from comment #2) > > Forgot to mention that this stage is executed regardless of success/failure. > > > Can we display something like "operation completed successfully" ? No... see above... this stage is executed regardless of success failure. > Ideally we would replace operation with the appropriate use (upgrade, etc) - > is that possible? Of course we can, but I try to avoid extra complexity at the core (otopi), it does not currently know what is happening. Maybe best to just remove this message? I can add silents rules... Or, I can add another message after the termination with the message you want. It will look like: [ INFO ] Stage: Termination [ INFO ] {action} completed successfully action ::= setup|cleanup|upgrade|rename (In reply to Alon Bar-Lev from comment #4) > > Or, I can add another message after the termination with the message you > want. It will look like: > > [ INFO ] Stage: Termination > [ INFO ] {action} completed successfully > > action ::= setup|cleanup|upgrade|rename Yes please. [ INFO ] Stage: Clean up [ INFO ] Stage: Pre-termination [ INFO ] Stage: Termination [ INFO ] Execution of upgrade completed successfully [ INFO ] Stage: Clean up [ INFO ] Stage: Pre-termination [ INFO ] Stage: Termination [ ERROR ] Execution of upgrade failed Closing - RHEV 3.3 Released Closing - RHEV 3.3 Released |